wip

Author: brendt

packages/database/src/functions.php

@@ -1,7 +1,6 @@
 <?php
 
 namespace Tempest\Database {
-    use ReflectionException;
     use Tempest\Database\Builder\ModelInspector;
     use Tempest\Database\Builder\QueryBuilders\QueryBuilder;
 

src/Tempest/Framework/Commands/MigrateDownCommand.php

@@ -5,6 +5,7 @@
 namespace Tempest\Framework\Commands;
 
 use Tempest\Console\Console;
+use Tempest\Console\ConsoleArgument;
 use Tempest\Console\ConsoleCommand;
 use Tempest\Console\Middleware\CautionMiddleware;
 use Tempest\Console\Middleware\ForceMiddleware;
@@ -28,9 +29,11 @@ public function __construct(
         description: 'Rollbacks all executed migrations',
         middleware: [ForceMiddleware::class, CautionMiddleware::class],
     )]
-    public function __invoke(): void
-    {
-        $this->migrationManager->down();
+    public function __invoke(
+        #[ConsoleArgument(description: 'Use a specific database.')]
+        ?string $database = null,
+    ): void {
+        $this->migrationManager->useDatabase($database)->down();
 
         $this->console->success(sprintf('Rolled back %s migrations', $this->count));
     }

src/Tempest/Framework/Commands/MigrateFreshCommand.php

@@ -34,6 +34,8 @@ public function __construct(
     public function __invoke(
         #[ConsoleArgument(description: 'Validates the integrity of existing migration files by checking if they have been tampered with.')]
         bool $validate = true,
+        #[ConsoleArgument(description: 'Use a specific database.')]
+        ?string $database = null,
     ): ExitCode {
         if ($validate) {
             $validationSuccess = $this->console->call(MigrateValidateCommand::class);
@@ -44,13 +46,13 @@ public function __invoke(
         }
 
         $this->console->header('Dropping tables');
-        $this->migrationManager->dropAll();
+        $this->migrationManager->useDatabase($database)->dropAll();
 
         if ($this->count === 0) {
             $this->console->info('There is no migration to drop.');
         }
 
-        return $this->console->call(MigrateUpCommand::class, ['fresh' => false, 'validate' => false]);
+        return $this->console->call(MigrateUpCommand::class, ['fresh' => false, 'validate' => false, 'database' => $database]);
     }
 
     #[EventHandler]

src/Tempest/Framework/Commands/MigrateUpCommand.php

@@ -39,6 +39,8 @@ public function __invoke(
         bool $validate = true,
         #[ConsoleArgument(description: 'Drops all tables and rerun migrations from scratch.')]
         bool $fresh = false,
+        #[ConsoleArgument(description: 'Use a specific database.')]
+        ?string $database = null,
     ): ExitCode {
         if ($validate) {
             $validationSuccess = $this->console->call(MigrateValidateCommand::class);
@@ -49,11 +51,11 @@ public function __invoke(
         }
 
         if ($fresh) {
-            return $this->console->call(MigrateFreshCommand::class, ['validate' => false, 'fresh' => false]);
+            return $this->console->call(MigrateFreshCommand::class, ['validate' => false, 'database' => $database]);
         }
 
         $this->console->header('Migrating');
-        $this->migrationManager->up();
+        $this->migrationManager->useDatabase($database)->up();
 
         if ($this->count === 0) {
             $this->console->info('There is no new migration to run.');

tests/Integration/Database/MultiDatabaseTest.php

@@ -2,13 +2,15 @@
 
 namespace Integration\Database;
 
+use PDOException;
 use Tempest\Container\Exceptions\CannotResolveTaggedDependency;
 use Tempest\Database\Config\DatabaseDialect;
 use Tempest\Database\Config\MysqlConfig;
 use Tempest\Database\Config\SQLiteConfig;
 use Tempest\Database\DatabaseInitializer;
 use Tempest\Database\Id;
 use Tempest\Database\Migrations\CreateMigrationsTable;
+use Tempest\Database\Migrations\Migration;
 use Tempest\Database\Migrations\MigrationManager;
 use Tests\Tempest\Fixtures\Migrations\CreatePublishersTable;
 use Tests\Tempest\Fixtures\Modules\Books\Models\Publisher;
@@ -17,6 +19,9 @@
 
 use function Tempest\Database\query;
 
+/**
+ * @property \Tempest\Console\Testing\ConsoleTester $console
+ */
 final class MultiDatabaseTest extends FrameworkIntegrationTestCase
 {
     protected function setUp(): void
@@ -151,7 +156,85 @@ public function test_fails_with_unknown_connection(): void
         }
     }
 
-    public function test_with_migration_command(): void
+    public function test_migrate_up_command(): void
     {
+        $this->console
+            ->call('migrate:up --database=main')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('main')->execute() > 0);
+
+        $this->assertException(
+            PDOException::class,
+            fn () => $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0),
+        );
+
+        $this->console
+            ->call('migrate:up --database=backup')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0);
+    }
+
+    public function test_migrate_fresh_command(): void
+    {
+        $this->console
+            ->call('migrate:fresh --database=main')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('main')->execute() > 0);
+
+        $this->assertException(
+            PDOException::class,
+            fn () => $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0),
+        );
+
+        $this->console
+            ->call('migrate:fresh --database=backup')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0);
+    }
+
+    public function test_migrate_up_fresh_command(): void
+    {
+        $this->console
+            ->call('migrate:up --fresh --database=main')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('main')->execute() > 0);
+
+        $this->assertException(
+            PDOException::class,
+            fn () => $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0),
+        );
+
+        $this->console
+            ->call('migrate:up --fresh --database=backup')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0);
+    }
+
+    public function test_migrate_down_command(): void
+    {
+        $this->console
+            ->call('migrate:up --database=main')
+            ->assertSuccess();
+
+        $this->console
+            ->call('migrate:up --database=backup')
+            ->assertSuccess();
+
+        $this->console
+            ->call('migrate:down --database=backup')
+            ->assertSuccess();
+
+        $this->assertTrue(query(Migration::class)->count()->useDatabase('main')->execute() > 0);
+
+        $this->assertException(
+            PDOException::class,
+            fn () => $this->assertTrue(query(Migration::class)->count()->useDatabase('backup')->execute() > 0),
+        );
     }
 }

tests/Integration/FrameworkIntegrationTestCase.php

@@ -4,6 +4,7 @@
 
 namespace Tests\Tempest\Integration;
 
+use Closure;
 use InvalidArgumentException;
 use Tempest\Console\ConsoleApplication;
 use Tempest\Console\Input\ConsoleArgumentBag;
@@ -32,6 +33,7 @@
 use Tempest\View\View;
 use Tempest\View\ViewConfig;
 use Tempest\View\ViewRenderer;
+use Throwable;
 
 use function Tempest\Support\Path\normalize;
 
@@ -188,4 +190,25 @@ protected function assertSameWithoutBackticks(string $expected, string $actual):
             $clean($actual),
         );
     }
+
+    protected function assertException(
+        string $expectedExceptionClass,
+        Closure $handler,
+        ?Closure $assertException = null,
+    ): void {
+        try {
+            $handler();
+        } catch (Throwable $throwable) {
+            $this->assertInstanceOf($expectedExceptionClass, $throwable);
+
+            if ($assertException !== null) {
+                $assertException($throwable);
+            }
+
+            return;
+        }
+
+        /* @phpstan-ignore-next-line */
+        $this->assertTrue(false, "Expected exception {$expectedExceptionClass} was not thrown");
+    }
 }

tests/Integration/TestingDatabaseInitializer.php

@@ -36,6 +36,7 @@ public function initialize(ClassReflector $class, null|string|UnitEnum $tag, Con
             default => '',
         };
 
+        /** @var PDOConnection|null $connection */
         $connection = self::$connections[$tag] ?? null;
 
         if ($connection === null) {
@@ -55,7 +56,6 @@ public function initialize(ClassReflector $class, null|string|UnitEnum $tag, Con
         return new GenericDatabase(
             $connection,
             new GenericTransactionManager($connection),
-            $container->get(DatabaseDialect::class),
         );
     }
 }