style: apply fixes from qa

Author: innocenzi

packages/core/src/functions.php

@@ -7,10 +7,8 @@
     use Stringable;
     use Tempest\Core\Composer;
     use Tempest\Core\DeferredTasks;
-    use Tempest\Core\Exceptions\ExceptionProcessor;
     use Tempest\Core\Kernel;
     use Tempest\Support\Namespace\PathCouldNotBeMappedToNamespace;
-    use Throwable;
 
     use function Tempest\Support\Namespace\to_psr4_namespace;
     use function Tempest\Support\Path\to_absolute_path;

packages/router/src/ExceptionRendererDiscovery.php

@@ -25,7 +25,7 @@ public function discover(DiscoveryLocation $location, ClassReflector $class): vo
             return;
         }
 
-        $priority = $class->getAttribute(Priority::class)?->priority ?? Priority::NORMAL;
+        $priority = $class->getAttribute(Priority::class)->priority ?? Priority::NORMAL;
 
         $this->discoveryItems->add($location, [$class->getName(), $priority]);
     }

packages/router/src/Exceptions/HtmlExceptionRenderer.php

@@ -6,7 +6,6 @@
 use Tempest\Container\Container;
 use Tempest\Core\AppConfig;
 use Tempest\Core\Priority;
-use Tempest\Discovery\SkipDiscovery;
 use Tempest\Http\ContentType;
 use Tempest\Http\GenericResponse;
 use Tempest\Http\HttpRequestFailed;

src/Tempest/Framework/Testing/Http/HttpRouterTester.php

@@ -183,7 +183,7 @@ private function createHeaders(array $headers = []): array
             callback: fn (mixed $_, string $headerKey): bool => strcasecmp($headerKey, 'accept') === 0,
         );
 
-        if ($this->contentType) {
+        if ($this->contentType !== null) {
             $headers[$key ?? 'accept'] = $this->contentType->value;
         }
 

src/Tempest/Framework/Testing/Http/TestResponseHelper.php

@@ -20,7 +20,6 @@
 use Tempest\Support\Arr;
 use Tempest\Support\Json;
 use Tempest\Validation\Rule;
-use Tempest\Validation\Validator;
 use Tempest\View\View;
 use Tempest\View\ViewRenderer;
 

tests/Integration/Router/ExceptionRendererTest.php

@@ -93,7 +93,7 @@ public function custom_json_exception_renderer(): void
             fn () => new GenericRequest(Method::GET, '/test', headers: ['Accept' => 'application/json']),
         );
 
-        $this->callExceptionHandler(function () {
+        $this->callExceptionHandler(function (): void {
             $handler = $this->container->get(HttpExceptionHandler::class);
             $handler->handle(new CustomValidationException('Custom validation failed'));
         });
@@ -117,7 +117,7 @@ public function custom_html_exception_renderer(): void
             fn () => new GenericRequest(Method::GET, '/test', headers: ['Accept' => 'text/html']),
         );
 
-        $this->callExceptionHandler(function () {
+        $this->callExceptionHandler(function (): void {
             $handler = $this->container->get(HttpExceptionHandler::class);
             $handler->handle(new CustomValidationException('Custom validation failed'));
         });
@@ -138,7 +138,7 @@ public function falls_back_to_default_renderer_when_no_custom_match(): void
             fn () => new GenericRequest(Method::GET, '/test', headers: ['Accept' => 'application/json']),
         );
 
-        $this->callExceptionHandler(function () {
+        $this->callExceptionHandler(function (): void {
             $handler = $this->container->get(HttpExceptionHandler::class);
             $handler->handle(new Exception('Regular exception'));
         });
@@ -160,7 +160,7 @@ public function priority_ordering(): void
             fn () => new GenericRequest(Method::GET, '/test', headers: ['Accept' => 'application/json']),
         );
 
-        $this->callExceptionHandler(function () {
+        $this->callExceptionHandler(function (): void {
             $handler = $this->container->get(HttpExceptionHandler::class);
             $handler->handle(new CustomValidationException('Test'));
         });