ci: slightly improve composer qa (#1095)

Author: innocenzi

composer.json

@@ -178,8 +178,8 @@
     "scripts": {
         "phpunit": "vendor/bin/phpunit --display-warnings --display-skipped --display-deprecations --display-errors --display-notices",
         "coverage": "vendor/bin/phpunit --coverage-html build/reports/html --coverage-clover build/reports/clover.xml",
-        "mago:fmt": "vendor/bin/mago fmt",
-        "mago:lint": "vendor/bin/mago lint --fix --fmt && vendor/bin/mago lint",
+        "mago:fmt": "vendor/bin/mago fmt && vendor/bin/mago lint --fix --potentially-unsafe --fmt",
+        "mago:lint": "vendor/bin/mago lint",
         "phpstan": "vendor/bin/phpstan analyse src tests --memory-limit=1G",
         "rector": "vendor/bin/rector process --no-ansi",
         "merge": "php -d\"error_reporting = E_ALL & ~E_DEPRECATED\" vendor/bin/monorepo-builder merge",
@@ -191,7 +191,7 @@
             "composer mago:fmt",
             "composer merge",
             "./bin/validate-packages",
-            "./tempest discovery:clear",
+            "./tempest discovery:clear --no-interaction",
             "composer rector",
             "composer phpunit",
             "composer mago:lint",

rector.php

@@ -37,7 +37,6 @@
         ],
     ])
     ->withRules([
-        ParenthesizeNestedTernaryRector::class,
         ExplicitNullableParamTypeRector::class,
     ])
     ->withSkip([

src/Tempest/Database/src/Builder/QueryBuilders/InsertQueryBuilder.php

@@ -23,7 +23,7 @@ public function __construct(
         $this->insert = new InsertStatement($this->resolveTableDefinition());
     }
 
-    public function execute(...$bindings): Id
+    public function execute(mixed ...$bindings): Id
     {
         return $this->build()->execute(...$bindings);
     }

src/Tempest/Database/src/Builder/QueryBuilders/UpdateQueryBuilder.php

@@ -30,7 +30,7 @@ public function __construct(
         );
     }
 
-    public function execute(...$bindings): Id
+    public function execute(mixed ...$bindings): Id
     {
         return $this->build()->execute(...$bindings);
     }

src/Tempest/Database/src/QueryStatements/InsertStatement.php

@@ -41,7 +41,7 @@ public function compile(DatabaseDialect $dialect): string
 
                 return sprintf(
                     '(%s)',
-                    $row->map(fn (mixed $value) => '?')->implode(', '),
+                    $row->map(fn () => '?')->implode(', '),
                 );
             })
             ->implode(', ');

src/Tempest/Database/src/QueryStatements/UpdateStatement.php

@@ -35,7 +35,7 @@ public function compile(DatabaseDialect $dialect): string
         }
 
         $query[] = 'SET ' . $this->values
-            ->map(fn (mixed $value, mixed $key) => sprintf("`{$key}` = ?"))
+            ->map(fn (mixed $_, mixed $key) => sprintf("`{$key}` = ?"))
             ->implode(', ');
 
         if ($this->where->isNotEmpty()) {

tests/bootstrap.php

@@ -6,5 +6,6 @@
 
 require_once __DIR__ . '/../vendor/autoload.php';
 
+echo PHP_EOL;
 passthru('php tempest discovery:generate --no-interaction');
 echo PHP_EOL;