chore(core): env detection improvements (#747)

Author: brendt

src/Tempest/Core/src/AppConfig.php

@@ -21,9 +21,7 @@ public function __construct(
             // …,
         ],
     ) {
-        $this->environment = $environment
-            ?? Environment::tryFrom(env('ENVIRONMENT', 'local'))
-            ?? Environment::LOCAL;
+        $this->environment = $environment ?? Environment::fromEnv();
 
         $this->baseUri = $baseUri ?? env('BASE_URI') ?? '';
     }

src/Tempest/Core/src/Environment.php

@@ -4,6 +4,8 @@
 
 namespace Tempest\Core;
 
+use function Tempest\env;
+
 enum Environment: string
 {
     case LOCAL = 'local';
@@ -42,4 +44,11 @@ public function isOther(): bool
     {
         return $this === self::OTHER;
     }
+
+    public static function fromEnv(): self
+    {
+        $value = env('ENVIRONMENT', 'production');
+
+        return self::tryFrom($value) ?? throw new InvalidEnvironment($value);
+    }
 }

src/Tempest/Core/src/InvalidEnvironment.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Core;
+
+use Exception;
+use function Tempest\Support\arr;
+
+final class InvalidEnvironment extends Exception
+{
+    public function __construct(string $value)
+    {
+        $possibleValues = arr(Environment::cases())->map(fn (Environment $environment) => $environment->value)->implode(', ');
+
+        parent::__construct("Invalid environment value `{$value}`, possible values are {$possibleValues}.");
+    }
+}

src/Tempest/Core/src/Kernel.php

@@ -12,7 +12,6 @@
 use Tempest\Core\Kernel\LoadConfig;
 use Tempest\Core\Kernel\LoadDiscoveryClasses;
 use Tempest\Core\Kernel\LoadDiscoveryLocations;
-use function Tempest\env;
 use Tempest\EventBus\EventBus;
 use Tempest\Http\Exceptions\HttpProductionErrorHandler;
 use Whoops\Handler\PrettyPageHandler;
@@ -177,7 +176,7 @@ private function event(object $event): self
 
     private function registerKernelErrorHandler(): self
     {
-        $environment = Environment::tryFrom(env('ENVIRONMENT', 'production'));
+        $environment = Environment::fromEnv();
 
         if ($environment->isTesting()) {
             return $this;