fix(reflection): return null for method return type if not defined (#1645)

Author: aazsamir

packages/reflection/src/MethodReflector.php

@@ -53,8 +53,12 @@ public function invokeArgs(?object $object, array $args = []): mixed
         return $this->reflectionMethod->invokeArgs($object, $args);
     }
 
-    public function getReturnType(): TypeReflector
+    public function getReturnType(): ?TypeReflector
     {
+        if ($this->reflectionMethod->getReturnType() === null) {
+            return null;
+        }
+
         return new TypeReflector($this->reflectionMethod->getReturnType());
     }
 

packages/reflection/tests/Fixtures/NoReturnType.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Reflection\Tests\Fixtures;
+
+final class NoReturnType
+{
+    // @mago-expect lint:return-type
+    public function noReturnType()
+    {
+        return 2137;
+    }
+}

packages/reflection/tests/MethodReflectorTest.php

@@ -5,6 +5,7 @@
 use PHPUnit\Framework\TestCase;
 use Tempest\Reflection\ClassReflector;
 use Tempest\Reflection\ParameterReflector;
+use Tempest\Reflection\Tests\Fixtures\NoReturnType;
 use Tempest\Reflection\Tests\Fixtures\TestClassA;
 
 final class MethodReflectorTest extends TestCase
@@ -24,4 +25,13 @@ public function test_get_parameter_by_name(): void
                 ->getParameter('unknown'),
         );
     }
+
+    public function test_no_return_type_returns_null(): void
+    {
+        $this->assertNull(
+            new ClassReflector(NoReturnType::class)
+                ->getMethod('noReturnType')
+                ->getReturnType(),
+        );
+    }
 }