refactor(kv-store): fix typo, correct type annotation, and fix TTL calculation (#1770)

Author: xHeaven

packages/kv-store/src/Redis/Config/RedisConfig.php

@@ -38,7 +38,7 @@ public function __construct(
         /**
          * Path of the UNIX domain socket file used when connecting to Redis using UNIX domain sockets.
          */
-        public ?int $unixSocketPath = null,
+        public ?string $unixSocketPath = null,
 
         /**
          * Specifies the protocol used to communicate with the Redis instance. This is specific to predis.

packages/kv-store/src/Redis/PhpRedisClient.php

@@ -99,7 +99,7 @@ public function command(Stringable|string $command, Stringable|string ...$argume
     public function set(Stringable|string $key, mixed $value, null|Duration|DateTimeInterface $expiration = null): void
     {
         if ($expiration instanceof DateTimeInterface) {
-            $expiration = DateTime::now()->since($expiration);
+            $expiration = $expiration->since(DateTime::now());
         }
 
         if ($expiration?->isNegative()) {

packages/kv-store/src/Redis/PredisClient.php

@@ -56,7 +56,7 @@ public function command(Stringable|string $command, Stringable|string ...$argume
     public function set(Stringable|string $key, mixed $value, null|Duration|DateTimeInterface $expiration = null): void
     {
         if ($expiration instanceof DateTimeInterface) {
-            $expiration = DateTime::now()->since($expiration);
+            $expiration = $expiration->since(DateTime::now());
         }
 
         if ($expiration?->isNegative()) {

…/src/Redis/ReddisExtensionWasMissing.php …e/src/Redis/RedisExtensionWasMissing.phppackages/kv-store/src/Redis/ReddisExtensionWasMissing.php renamed to packages/kv-store/src/Redis/RedisExtensionWasMissing.php packages/kv-store/src/Redis/ReddisExtensionWasMissing.php renamed to packages/kv-store/src/Redis/RedisExtensionWasMissing.php

@@ -5,7 +5,7 @@
 use Exception;
 use Predis;
 
-final class ReddisExtensionWasMissing extends Exception implements RedisException
+final class RedisExtensionWasMissing extends Exception implements RedisException
 {
     public function __construct(string $fqcn)
     {

packages/kv-store/src/Redis/RedisInitializer.php

@@ -19,15 +19,15 @@ public function initialize(Container $container): Redis
 
         try {
             return new PhpRedisClient($this->buildPhpRedisClient(), $config, $bus);
-        } catch (ReddisExtensionWasMissing) {
+        } catch (RedisExtensionWasMissing) {
             return new PredisClient($this->buildPredisClient($config), $bus);
         }
     }
 
     private function buildPhpRedisClient(): \Redis
     {
         if (! extension_loaded('redis') || ! class_exists(\Redis::class)) {
-            throw new ReddisExtensionWasMissing(\Redis::class);
+            throw new RedisExtensionWasMissing(\Redis::class);
         }
 
         return new \Redis();
@@ -36,7 +36,7 @@ private function buildPhpRedisClient(): \Redis
     private function buildPredisClient(RedisConfig $config): Predis\Client
     {
         if (! class_exists(Predis\Client::class)) {
-            throw new ReddisExtensionWasMissing(Predis\Client::class);
+            throw new RedisExtensionWasMissing(Predis\Client::class);
         }
 
         return new Predis\Client(