wip

Author: brendt

src/Tempest/Validation/src/Rules/IsFloat.php

@@ -20,6 +20,10 @@ public function isValid(mixed $value): bool
             return true;
         }
 
+        if ($value === null || $value === false || $value === '') {
+            return false;
+        }
+
         if (floatval($value) == $value) {
             return true;
         }

src/Tempest/Validation/src/Rules/IsInteger.php

@@ -20,11 +20,7 @@ public function isValid(mixed $value): bool
             return true;
         }
 
-        if ($value === null) {
-            return false;
-        }
-
-        if ($value === '') {
+        if ($value === null || $value === false || $value === '') {
             return false;
         }
 

src/Tempest/Validation/tests/Rules/IsFloatTest.php

@@ -20,5 +20,8 @@ public function test_float(): void
         $this->assertTrue($rule->isValid(0.1));
         $this->assertTrue($rule->isValid('0.1'));
         $this->assertFalse($rule->isValid('a'));
+        $this->assertFalse($rule->isValid(''));
+        $this->assertFalse($rule->isValid(null));
+        $this->assertFalse($rule->isValid(false));
     }
 }

src/Tempest/Validation/tests/Rules/IsIntegerTest.php

@@ -20,5 +20,7 @@ public function test_integer(): void
         $this->assertTrue($rule->isValid('1'));
         $this->assertFalse($rule->isValid('a'));
         $this->assertFalse($rule->isValid(''));
+        $this->assertFalse($rule->isValid(null));
+        $this->assertFalse($rule->isValid(false));
     }
 }