test: improve coverage

Author: innocenzi

src/Tempest/Support/src/Filesystem/Exceptions/NotFoundException.php

@@ -6,9 +6,9 @@
 
 final class NotFoundException extends Exception implements FilesystemException
 {
-    public static function forNode(string $node): static
+    public static function forPath(string $path): static
     {
-        return new self(sprintf('Node "%s" is not found.', $node));
+        return new self(sprintf('Path "%s" is not found.', $path));
     }
 
     public static function forFile(string $file): static

src/Tempest/Support/src/Filesystem/functions.php

@@ -241,7 +241,7 @@ function delete_file(string $file): void
     function get_permissions(string $path): int
     {
         if (! namespace\exists($path)) {
-            throw Exceptions\NotFoundException::forNode($path);
+            throw Exceptions\NotFoundException::forPath($path);
         }
 
         [$result, $message] = box(static fn (): int|false => fileperms($path));
@@ -271,7 +271,9 @@ function ensure_directory_empty(string $directory): void
             return;
         }
 
-        $permissions = namespace\get_permissions($directory);
+        $permissions = PHP_OS_FAMILY === 'Windows'
+            ? namespace\get_permissions($directory)
+            : 0o777;
 
         namespace\delete_directory($directory, recursive: true);
         namespace\create_directory($directory, $permissions);

src/Tempest/Support/tests/Filesystem/FunctionsTest.php

@@ -8,6 +8,7 @@
 use Tempest\Support\Filesystem\Exceptions\NotFileException;
 use Tempest\Support\Filesystem\Exceptions\NotFoundException;
 use Tempest\Support\Filesystem\Exceptions\NotReadableException;
+use Tempest\Support\Filesystem\Exceptions\NotSymbolicLinkException;
 use Tempest\Support\Filesystem\Exceptions\RuntimeException;
 
 final class FunctionsTest extends TestCase
@@ -197,6 +198,17 @@ public function test_get_permissions(): void
         $this->assertEquals(0o644, $permissions & 0o777);
     }
 
+    public function test_get_permissions_not_found(): void
+    {
+        if (PHP_OS_FAMILY === 'Windows') {
+            $this->markTestSkipped('Irrelevant on Windows.');
+        }
+
+        $this->expectException(NotFoundException::class);
+
+        Filesystem\get_permissions($this->fixtures . '/file.txt');
+    }
+
     public function test_ensure_directory_empty(): void
     {
         $dir = $this->fixtures . '/tmp';
@@ -310,6 +322,17 @@ public function test_list_directory(): void
         }
     }
 
+    public function test_list_directory_on_non_directory(): void
+    {
+        $this->expectException(NotDirectoryException::class);
+
+        $file = $this->fixtures . '/file.txt';
+
+        file_put_contents($file, '');
+
+        Filesystem\list_directory($file);
+    }
+
     public function test_read_symbolic_link(): void
     {
         $file = $this->fixtures . '/file.txt';
@@ -323,6 +346,21 @@ public function test_read_symbolic_link(): void
         $this->assertEquals(realpath($file), $target);
     }
 
+    public function test_read_symbolic_link_on_non_symlink(): void
+    {
+        if (PHP_OS_FAMILY === 'Windows') {
+            $this->markTestSkipped('Irrelevant on Windows.');
+        }
+
+        $this->expectException(NotSymbolicLinkException::class);
+
+        $file = $this->fixtures . '/file.txt';
+
+        file_put_contents($file, '');
+
+        Filesystem\read_symbolic_link($file);
+    }
+
     public function test_get_directory(): void
     {
         $file = $this->fixtures . '/file.txt';
@@ -410,6 +448,10 @@ public function test_write_file(): void
 
     public function test_write_non_writable_file(): void
     {
+        if (PHP_OS_FAMILY === 'Windows') {
+            $this->markTestSkipped('Irrelevant on Windows.');
+        }
+
         $this->expectException(RuntimeException::class);
 
         $file = $this->fixtures . '/file.txt';