feat(view): default slot content (#1300)

brendt · web-flow · commit d1a21b0d6c9a · 2025-06-24T13:08:46.000+02:00
diff --git a/packages/view/src/Elements/ViewComponentElement.php b/packages/view/src/Elements/ViewComponentElement.php
@@ -158,19 +158,33 @@ public function compile(): string
             )
             // Compile slots
             ->replaceRegex(
-                regex: '/<x-slot\s*(name="(?<name>[\w-]+)")?((\s*\/>)|><\/x-slot>)/',
+                regex: '/<x-slot\s*(name="(?<name>[\w-]+)")?((\s*\/>)|>(?<default>(.|\n)*?)<\/x-slot>)/',
                 replace: function ($matches) {
                     $name = $matches['name'] ?: 'slot';
 
                     $slot = $this->getSlot($name);
 
+                    $default = $matches['default'] ?? null;
+
                     if ($slot === null) {
+                        if ($default) {
+                            // There's no slot, but there's a default value in the view component
+                            return $default;
+                        }
+
                         // A slot doesn't have any content, so we'll comment it out.
                         // This is to prevent DOM parsing errors (slots in <head> tags is one example, see #937)
                         return $this->environment->isProduction() ? '' : ('<!--' . $matches[0] . '-->');
                     }
 
-                    return $slot->compile();
+                    $compiled = $slot->compile();
+
+                    // There's no default slot content, but there's a default value in the view component
+                    if (trim($compiled) === '') {
+                        return $default;
+                    }
+
+                    return $compiled;
                 },
             );
 
diff --git a/tests/Integration/View/ViewComponentTest.php b/tests/Integration/View/ViewComponentTest.php
@@ -897,4 +897,44 @@ public function test_escape_expression_attribute_in_view_components(): void
 
         $this->assertSnippetsMatch('<div class="foo" :escaped="foo"></div>', $html);
     }
+
+    public function test_default_slot_value(): void
+    {
+        $this->registerViewComponent('x-test', <<<'HTML'
+        <x-slot>Default</x-slot>
+        <x-slot name="a">Default A</x-slot>
+        <x-slot name="b">Default B</x-slot>
+        HTML);
+
+        $this->assertSnippetsMatch(
+            <<<'HTML'
+            Overwritten
+            Overwritten A
+            Overwritten B
+            HTML,
+            $this->render('<x-test>
+        Overwritten
+        <x-slot name="a">Overwritten A</x-slot>
+        <x-slot name="b">Overwritten B</x-slot>
+        </x-test>'),
+        );
+
+        $this->assertSnippetsMatch(
+            <<<'HTML'
+            Overwritten
+            Default A
+            Overwritten B
+            HTML,
+            $this->render('<x-test>
+        Overwritten
+        <x-slot name="b">Overwritten B</x-slot>
+        </x-test>'),
+        );
+
+        $this->assertSnippetsMatch(<<<'HTML'
+        Default
+        Default A
+        Default B
+        HTML, $this->render('<x-test></x-test>'));
+    }
 }
