fix(support): non-dev bun dependencies installation (#1124)

Author: erikaraujo

src/Tempest/Support/src/JavaScript/DependencyInstaller.php

@@ -58,11 +58,17 @@ public function silentlyInstallDependencies(string $cwd, string|array $dependenc
      */
     private function getInstallProcess(PackageManager $packageManager, string $cwd, string|array $dependencies, bool $dev = false): Process
     {
-        return new Process([
-            $packageManager->getBinaryName(),
-            $packageManager->getInstallCommand(),
-            $dev ? '-D' : '',
-            ...wrap($dependencies),
-        ], $cwd);
+        return new Process(
+            array_filter(
+                [
+                    $packageManager->getBinaryName(),
+                    $packageManager->getInstallCommand(),
+                    $dev ? '-D' : null,
+                    ...wrap($dependencies),
+                ],
+                fn (?string $arg): bool => $arg !== null,
+            ),
+            $cwd,
+        );
     }
 }

tests/Integration/Support/DependencyInstallerTest.php

@@ -58,6 +58,22 @@ public function test_asks_for_package_manager(): void
         });
     }
 
+    #[TestWith(['bun.lock'])]
+    #[TestWith(['package-lock.json'])]
+    public function test_can_install_non_dev_dependencies(string $lockfile): void
+    {
+        $this->callInTemporaryDirectory(function (string $directory) use ($lockfile): void {
+            file_put_contents("{$directory}/package.json", data: '{}');
+            file_put_contents("{$directory}/{$lockfile}", data: null);
+
+            $installer = $this->container->get(DependencyInstaller::class);
+            $installer->silentlyInstallDependencies($directory, 'vite-plugin-tempest', dev: false);
+
+            $this->assertTrue(is_dir($directory . '/node_modules'), message: 'Dependencies were not installed.');
+            $this->assertNotNull(json_decode(file_get_contents($directory . '/package.json'), associative: true)['dependencies']['vite-plugin-tempest']);
+        });
+    }
+
     private function callInTemporaryDirectory(Closure $callback): void
     {
         $directory = __DIR__ . '/Fixtures/tmp';