refactor(support): add validation and fix edge cases in array helpers (#1779)

Author: xHeaven

packages/support/src/Arr/IsIterable.php

@@ -24,7 +24,7 @@ public function key(): string|int|null
 
     public function valid(): bool
     {
-        return $this->current() !== false;
+        return $this->key() !== null;
     }
 
     public function rewind(): void

packages/support/src/Arr/functions.php

@@ -516,6 +516,12 @@ function combine(iterable $array, iterable $values): array
         $array = to_array($array);
         $values = to_array($values);
 
+        if (count($array) !== count($values)) {
+            throw new InvalidArgumentException(
+                sprintf('Cannot combine arrays of different lengths (%d keys vs %d values)', count($array), count($values)),
+            );
+        }
+
         return array_combine($array, $values);
     }
 
@@ -792,6 +798,10 @@ function get_by_key(iterable $array, int|string $key, mixed $default = null): mi
             : explode('.', $key);
 
         foreach ($keys as $key) {
+            if (! is_array($value) && ! $value instanceof \ArrayAccess) {
+                return $default;
+            }
+
             if (! isset($value[$key])) {
                 return $default;
             }
@@ -843,11 +853,12 @@ function has_key(iterable $array, int|string $key): bool
      */
     function contains(iterable $array, mixed $search): bool
     {
+        $array = to_array($array);
         $search = $search instanceof Closure
             ? $search
             : static fn (mixed $value) => $value === $search;
 
-        return namespace\first(to_array($array), $search) !== null;
+        return array_any($array, static fn ($value, $key) => $search($value, $key));
     }
 
     /**