fix: duplicate command completion (#600)

Signed-off-by: Tonko Mulder <[email protected]>
Co-authored-by: Frank Kemps <[email protected]>
Co-authored-by: Brent Roose <[email protected]>

Author: 3 people

src/Tempest/Console/src/Middleware/ResolveOrRescueMiddleware.php

@@ -65,6 +65,10 @@ private function getSimilarCommands(string $name): array
         $similarCommands = [];
 
         foreach ($this->consoleConfig->commands as $consoleCommand) {
+            if (in_array($consoleCommand->getName(), $similarCommands, strict: true)) {
+                continue;
+            }
+
             if (str_starts_with($consoleCommand->getName(), $name)) {
                 $similarCommands[] = $consoleCommand->getName();
 

src/Tempest/Console/src/Testing/ConsoleTester.php

@@ -160,6 +160,19 @@ public function printFormatted(): self
         return $this;
     }
 
+    public function getBuffer(?callable $callback = null): array
+    {
+        $buffer = array_map('trim', $this->output->getBufferWithoutFormatting());
+
+        $this->output->clear();
+
+        if ($callback !== null) {
+            return $callback($buffer);
+        }
+
+        return $buffer;
+    }
+
     public function useInteractiveTerminal(): self
     {
         $this->componentRenderer = new InteractiveComponentRenderer();

tests/Integration/Console/Middleware/ResolveOrRescueMiddlewareTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Tempest\Integration\Console\Middleware;
+
+use PHPUnit\Framework\Attributes\Test;
+use Tests\Tempest\Integration\FrameworkIntegrationTestCase;
+
+/**
+ * @internal
+ */
+final class ResolveOrRescueMiddlewareTest extends FrameworkIntegrationTestCase
+{
+    #[Test]
+    public function it_can_find_a_single_similar_command(): void
+    {
+        $this->console
+            ->call('discovery:sta')
+            ->assertSee('Did you mean discovery:status?');
+
+        $this->console
+            ->call('bascovery:status')
+            ->assertSee('Did you mean discovery:status?');
+    }
+
+    #[Test]
+    public function it_does_not_duplicate_completed_commands(): void
+    {
+        $formatOutput = static fn (string $buffer) => str($buffer)
+            ->trim()
+            ->remove(['[',']'])
+            ->explode('/')
+            ->all();
+
+        $output = $this->console
+            ->call('discovery')
+            ->getBuffer(fn (array $buffer) => $formatOutput(array_pop($buffer)));
+
+        $this->assertContains('discovery:status', $output);
+        $this->assertContains('discovery:clear', $output);
+
+        $this->assertCount(2, $output);
+    }
+}