fix(view): remove multiline comments before AST parsing (#1395)

Author: xHeaven

packages/view/src/Elements/TextElement.php

@@ -19,11 +19,6 @@ public function __construct(
     public function compile(): string
     {
         return str($this->text)
-            // Render {{-- --}}
-            ->replaceRegex(
-                regex: '/{{--(.|\n)*?--}}/',
-                replace: '',
-            )
             // Render {{
             ->replaceRegex(
                 regex: '/{{(?<match>.*?)}}/',

packages/view/src/Parser/TempestViewCompiler.php

@@ -41,24 +41,34 @@ public function compile(string|View $view): string
         // 1. Retrieve template
         $template = $this->retrieveTemplate($view);
 
-        // 2. Parse AST
+        // 2. Remove comments before parsing
+        $template = $this->removeComments($template);
+
+        // 3. Parse AST
         $ast = $this->parseAst($template);
 
-        // 3. Map to elements
+        // 4. Map to elements
         $elements = $this->mapToElements($ast);
 
-        // 4. Apply attributes
+        // 5. Apply attributes
         $elements = $this->applyAttributes($elements);
 
-        // 5. Compile to PHP
+        // 6. Compile to PHP
         $compiled = $this->compileElements($elements);
 
-        // 6. Cleanup compiled PHP
+        // 7. Cleanup compiled PHP
         $cleaned = $this->cleanupCompiled($compiled);
 
         return $cleaned;
     }
 
+    private function removeComments(string $template): string
+    {
+        return str($template)
+            ->replaceRegex('/{{--.*?--}}/s', '')
+            ->toString();
+    }
+
     private function retrieveTemplate(string|View $view): string
     {
         $path = ($view instanceof View) ? $view->path : $view;

tests/Integration/View/TempestViewRendererTest.php

@@ -727,4 +727,24 @@ public function test_view_comments(): void
 
         $this->assertSnippetsMatch('<p>this is rendered text</p>', $html);
     }
+
+    public function test_multiline_view_comments(): void
+    {
+        $html = $this->render(<<<'HTML'
+        {{-- this is a comment
+                <div>
+                    <!-- Start -->
+                    <x-label>{{ Tempest\Intl\translate('test_2') }}</x-label>
+                <x-input
+                    name="test"
+                    type="text"
+                    class="py-2.5 sm:py-3 px-4 block w-full border-gray-500 border-1 rounded-lg sm:text-sm focus:border-blue-500 focus:ring-blue-500 disabled:opacity-50 disabled:pointer-events-none dark:bg-neutral-900 dark:border-neutral-700 dark:text-neutral-400 dark:placeholder-neutral-500 dark:focus:ring-neutral-600" placeholder="This is placeholder" />
+                <!-- end -->
+            </div>
+            --}}
+        <p>This should be rendered</p>
+        HTML);
+
+        $this->assertSnippetsMatch('<p>This should be rendered</p>', $html);
+    }
 }