refactor(console): error if no acceptable shell detected

Author: xHeaven

packages/console/src/Commands/CompletionInstallCommand.php

@@ -38,6 +38,12 @@ public function __invoke(
     ): ExitCode {
         $shell ??= $this->resolveShell();
 
+        if ($shell === null) {
+            $this->console->error('Could not detect shell. Please specify one using the --shell option. Possible values are: zsh, bash.');
+
+            return ExitCode::ERROR;
+        }
+
         $sourcePath = $this->getSourcePath($shell);
         $targetDir = $shell->getCompletionsDirectory();
         $targetPath = $shell->getInstalledCompletionPath();
@@ -81,7 +87,7 @@ public function __invoke(
         return ExitCode::SUCCESS;
     }
 
-    private function resolveShell(): Shell
+    private function resolveShell(): ?Shell
     {
         $detected = Shell::detect();
 

packages/console/src/Commands/CompletionShowCommand.php

@@ -33,6 +33,12 @@ public function __invoke(
     ): ExitCode {
         $shell ??= $this->resolveShell();
 
+        if ($shell === null) {
+            $this->console->error('Could not detect shell. Please specify one using the --shell option. Possible values are: zsh, bash.');
+
+            return ExitCode::ERROR;
+        }
+
         $sourcePath = $this->getSourcePath($shell);
 
         if (! Filesystem\is_file($sourcePath)) {
@@ -46,7 +52,7 @@ public function __invoke(
         return ExitCode::SUCCESS;
     }
 
-    private function resolveShell(): Shell
+    private function resolveShell(): ?Shell
     {
         $detected = Shell::detect();
 

packages/console/src/Commands/CompletionUninstallCommand.php

@@ -35,6 +35,12 @@ public function __invoke(
     ): ExitCode {
         $shell ??= $this->resolveShell();
 
+        if ($shell === null) {
+            $this->console->error('Could not detect shell. Please specify one using the --shell option. Possible values are: zsh, bash.');
+
+            return ExitCode::ERROR;
+        }
+
         $targetPath = $shell->getInstalledCompletionPath();
 
         if (! Filesystem\is_file($targetPath)) {
@@ -66,7 +72,7 @@ public function __invoke(
         return ExitCode::SUCCESS;
     }
 
-    private function resolveShell(): Shell
+    private function resolveShell(): ?Shell
     {
         $detected = Shell::detect();
 

packages/console/src/Enums/Shell.php

@@ -9,18 +9,18 @@ enum Shell: string
     case ZSH = 'zsh';
     case BASH = 'bash';
 
-    public static function detect(): self
+    public static function detect(): ?self
     {
         $shell = getenv('SHELL');
 
         if ($shell === false) {
-            return self::BASH;
+            return null;
         }
 
         return match (true) {
             str_contains($shell, 'zsh') => self::ZSH,
             str_contains($shell, 'bash') => self::BASH,
-            default => self::BASH,
+            default => null,
         };
     }