refactor: general codebase upgrade to latest practices (#883)

Author: xHeaven

.php-cs-fixer.dist.php

@@ -93,6 +93,7 @@
             'on_multiline' => 'ensure_fully_multiline',
             'keep_multiple_spaces_after_comma' => true,
         ],
+        'type_declaration_spaces' => true,
         'single_trait_insert_per_statement' => true,
         'declare_strict_types' => true,
         'no_empty_comment' => true,

bin/release

@@ -31,7 +31,7 @@ function getCurrentVersion(): string
 
 function normalizeVersion(string $version): string
 {
-    return preg_replace('/^(\d+\.\d+\.\d+)\.0(-|$|\+)/', '$1$2', (new VersionParser())->normalize($version));
+    return preg_replace('/^(\d+\.\d+\.\d+)\.0(-|$|\+)/', '$1$2', new VersionParser()->normalize($version));
 }
 
 function suggestNextVersions(string $current): array

composer.json

@@ -44,15 +44,15 @@
         "jenssegers/blade": "^2.0",
         "mikey179/vfsstream": "^2.0@dev",
         "nyholm/psr7": "^1.8",
+        "phpat/phpat": "^0.11.0",
         "phpbench/phpbench": "84.x-dev",
         "phpstan/phpstan": "^2.0",
         "phpunit/phpunit": "^11.3.5",
         "rector/rector": "^2.0-rc2",
         "spatie/phpunit-snapshot-assertions": "^5.1.6",
         "spaze/phpstan-disallowed-calls": "^4.0",
         "symplify/monorepo-builder": "^11.2",
-        "twig/twig": "^3.16",
-        "phpat/phpat": "^0.11.0"
+        "twig/twig": "^3.16"
     },
     "replace": {
         "tempest/auth": "self.version",

phpstan.neon.dist

@@ -18,6 +18,8 @@ parameters:
 		- src
 		- tests
 	ignoreErrors:
+		-
+			identifier: assign.propertyReadOnly
 		-
 			identifier: argument.named
 		-

rector.php

@@ -6,7 +6,6 @@
 use Rector\Caching\ValueObject\Storage\FileCacheStorage;
 use Rector\CodingStyle\Rector\Encapsed\EncapsedStringsToSprintfRector;
 use Rector\Config\RectorConfig;
-use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPublicMethodParameterRector;
 use Rector\DeadCode\Rector\PropertyProperty\RemoveNullPropertyInitializationRector;
 use Rector\Php70\Rector\StaticCall\StaticCallOnNonStaticToInstanceCallRector;
 use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
@@ -51,7 +50,6 @@
         ReadOnlyPropertyRector::class,
         RemoveNullPropertyInitializationRector::class,
         AddSensitiveParameterAttributeRector::class,
-        RemoveUnusedPublicMethodParameterRector::class,
         RestoreDefaultNullToNullableTypePropertyRector::class,
         ReturnNeverTypeRector::class,
         StaticCallOnNonStaticToInstanceCallRector::class,

src/Tempest/Auth/src/Install/CreateUserPermissionsTable.php

@@ -16,7 +16,7 @@ final class CreateUserPermissionsTable implements DatabaseMigration
 
     public function up(): CreateTableStatement
     {
-        return (new CreateTableStatement('user_permissions'))
+        return new CreateTableStatement('user_permissions')
             ->primary()
             ->belongsTo('user_permissions.user_id', 'users.id')
             ->belongsTo('user_permissions.permission_id', 'permissions.id');

src/Tempest/Auth/src/Install/User.php

@@ -41,10 +41,10 @@ public function grantPermission(string|UnitEnum|Permission $permission): self
     {
         $permission = $this->resolvePermission($permission);
 
-        (new UserPermission(
+        new UserPermission(
             user: $this,
             permission: $permission,
-        ))->save();
+        )->save();
 
         return $this->load('userPermissions.permission');
     }
@@ -81,10 +81,6 @@ private function resolvePermission(string|UnitEnum|Permission $permission): Perm
 
         $permission = Permission::query()->whereField('name', $name)->first();
 
-        if ($permission === null) {
-            return (new Permission($name))->save();
-        }
-
-        return $permission;
+        return $permission ?? new Permission($name)->save();
     }
 }

src/Tempest/Clock/tests/GenericClockTest.php

@@ -47,7 +47,7 @@ public function test_that_generic_clock_sleeps(): void
     {
         $timeBefore = time();
 
-        (new GenericClock())->sleep(1);
+        new GenericClock()->sleep(1);
 
         $timeAfter = time();
 

src/Tempest/CommandBus/src/MonitorAsyncCommands.php

@@ -55,7 +55,7 @@ public function __invoke(): void
             }
 
             $availableCommands = arr($this->repository->getPendingCommands())
-                ->filter(fn (object $command, string $uuid) => ! in_array($uuid, array_keys($processes)));
+                ->filter(fn (object $command, string $uuid) => ! array_key_exists($uuid, $processes));
 
             if (count($processes) === 5) {
                 $this->sleep(0.5);

src/Tempest/Console/src/Actions/ResolveConsoleCommand.php

@@ -8,10 +8,10 @@
 use Tempest\Console\ConsoleCommand;
 use Tempest\Console\ConsoleConfig;
 
-final class ResolveConsoleCommand
+final readonly class ResolveConsoleCommand
 {
     public function __construct(
-        private readonly ConsoleConfig $consoleConfig,
+        private ConsoleConfig $consoleConfig,
     ) {
     }