refactor(router): make optional segment check stricter

xHeaven · xHeaven · commit fc5735d7bc9a · 2025-11-13T16:38:57.000+01:00
diff --git a/packages/router/src/Routing/Construction/RoutingTree.php b/packages/router/src/Routing/Construction/RoutingTree.php
@@ -46,7 +46,7 @@ public function add(MarkedRoute $markedRoute): void
 
     private function isOptionalSegment(string $segment): bool
     {
-        return str_contains($segment, '?');
+        return str_starts_with($segment, '{?');
     }
 
     private function stripOptionalMarker(string $segment): string

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public function add(MarkedRoute $markedRoute): void`
`46`	`46`
`47`	`47`	`private function isOptionalSegment(string $segment): bool`
`48`	`48`	`{`
`49`		`- return str_contains($segment, '?');`
	`49`	`+ return str_starts_with($segment, '{?');`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`private function stripOptionalMarker(string $segment): string`