refactor(reflection): improve type handling and add safety checks (#1777)

Author: xHeaven

packages/reflection/src/PropertyReflector.php

@@ -98,13 +98,15 @@ public function getIterableType(): ?TypeReflector
             return null;
         }
 
-        preg_match('/@var ([\\\\\w]+)\[]/', $doc, $match);
+        if (preg_match('/@var\s+([\\\\\w]+)\[\]/', $doc, $match)) {
+            return new TypeReflector(ltrim($match[1], '\\'));
+        }
 
-        if (! isset($match[1])) {
-            return null;
+        if (preg_match('/@var\s+(?:list|array)<([\\\\\w]+)>/', $doc, $match)) {
+            return new TypeReflector(ltrim($match[1], '\\'));
         }
 
-        return new TypeReflector(ltrim($match[1], '\\'));
+        return null;
     }
 
     public function isUninitialized(object $object): bool
@@ -151,7 +153,7 @@ public function hasDefaultValue(): bool
 
         $hasDefaultValue = $this->reflectionProperty->hasDefaultValue();
 
-        $hasPromotedDefaultValue = $this->isPromoted() && $constructorParameters[$this->getName()]->isDefaultValueAvailable();
+        $hasPromotedDefaultValue = $this->isPromoted() && isset($constructorParameters[$this->getName()]) && $constructorParameters[$this->getName()]->isDefaultValueAvailable();
 
         return $hasDefaultValue || $hasPromotedDefaultValue;
     }

packages/reflection/src/TypeReflector.php

@@ -6,7 +6,6 @@
 
 use BackedEnum;
 use DateTimeInterface;
-use Exception;
 use Generator;
 use Iterator;
 use ReflectionClass as PHPReflectionClass;
@@ -232,7 +231,13 @@ private function resolveDefinition(PHPReflector|PHPReflectionType|string $reflec
         }
 
         if ($reflector instanceof PHPReflectionParameter || $reflector instanceof PHPReflectionProperty) {
-            return $this->resolveDefinition($reflector->getType());
+            $type = $reflector->getType();
+
+            if ($type === null) {
+                return 'mixed';
+            }
+
+            return $this->resolveDefinition($type);
         }
 
         if ($reflector instanceof PHPReflectionClass) {
@@ -257,7 +262,9 @@ private function resolveDefinition(PHPReflector|PHPReflectionType|string $reflec
             ));
         }
 
-        throw new Exception('Could not resolve type');
+        throw new \InvalidArgumentException(
+            sprintf('Could not resolve type for reflector of type: %s', get_debug_type($reflector)),
+        );
     }
 
     private function resolveIsNullable(PHPReflectionType|PHPReflector|string $reflector): bool
@@ -267,7 +274,9 @@ private function resolveIsNullable(PHPReflectionType|PHPReflector|string $reflec
         }
 
         if ($reflector instanceof PHPReflectionParameter || $reflector instanceof PHPReflectionProperty) {
-            return $reflector->getType()->allowsNull();
+            $type = $reflector->getType();
+
+            return $type === null || $type->allowsNull();
         }
 
         if ($reflector instanceof PHPReflectionType) {