rename: http_root -> s3_root

Author: effigies

templateflow/client.py

@@ -339,7 +339,7 @@ def _s3_get(config: CacheConfig, filepath: Path):
     from tqdm import tqdm
 
     path = quote(filepath.relative_to(config.root).as_posix())
-    url = f'{config.http_root}/{path}'
+    url = f'{config.s3_root}/{path}'
 
     print(f'Downloading {url}', file=stderr)
     # Streaming, so we can iterate over the response.

templateflow/conf/__init__.py

@@ -19,7 +19,7 @@ def __getattr__(name: str):
     elif name == 'TF_GITHUB_SOURCE':
         return _cache.config.origin
     elif name == 'TF_S3_ROOT':
-        return _cache.config.http_root
+        return _cache.config.s3_root
     elif name == 'TF_USE_DATALAD':
         return _cache.config.use_datalad
     elif name == 'TF_AUTOUPDATE':

templateflow/conf/cache.py

@@ -13,7 +13,7 @@
 class CacheConfig:
     root: Path = field(default_factory=get_templateflow_home)
     origin: str = field(default='https://github.com/templateflow/templateflow.git')
-    http_root: str = field(default='https://templateflow.s3.amazonaws.com')
+    s3_root: str = field(default='https://templateflow.s3.amazonaws.com')
     use_datalad: bool = field(default_factory=env_to_bool('TEMPLATEFLOW_USE_DATALAD', False))
     autoupdate: bool = field(default_factory=env_to_bool('TEMPLATEFLOW_AUTOUPDATE', True))
     timeout: int = field(default=10)
@@ -27,7 +27,7 @@ def __post_init__(self):
 
 @dataclass
 class S3Manager:
-    http_root: str
+    s3_root: str
 
     def install(self, path: Path, overwrite: bool, timeout: int):
         from ._s3 import update
@@ -88,7 +88,7 @@ def __post_init__(self):
         self.manager = (
             DataladManager(self.config.origin)
             if self.config.use_datalad
-            else S3Manager(self.config.http_root)
+            else S3Manager(self.config.s3_root)
         )
         # cache.cached checks live, precached stores state at init
         self.precached = self.cached