test: Mock 400 response just once

Author: effigies

templateflow/tests/test_s3.py

@@ -93,18 +93,19 @@ def test_update_s3(tmp_path, monkeypatch):
     assert tfc._s3.update(newhome, local=False, overwrite=False)
 
 
+def mock_get(*args, **kwargs):
+    class MockResponse:
+        status_code = 400
+
+    return MockResponse()
+
+
 def test_s3_400_error(monkeypatch):
     """Simulate a 400 error when fetching the skeleton file."""
 
     reload(tfc)
     reload(tf)
 
-    def mock_get(*args, **kwargs):
-        class MockResponse:
-            status_code = 400
-
-        return MockResponse()
-
     monkeypatch.setattr(requests, 'get', mock_get)
     with pytest.raises(RuntimeError):
         tf._s3_get(
@@ -142,13 +143,6 @@ def test_bad_skeleton(tmp_path, monkeypatch):
 
     path.write_bytes(error_file.read_bytes())
 
-    # Run full get but mock 400 to avoid actual network call
-    def mock_get(*args, **kwargs):
-        class MockResponse:
-            status_code = 400
-
-        return MockResponse()
-
     monkeypatch.setattr(requests, 'get', mock_get)
     with pytest.raises(RuntimeError):
         tf.get('MNI152NLin2009cAsym', resolution='02', suffix='T1w', desc=None)