Apply suggestions from code review

mgxd · oesteban · web-flow · commit a9f7f5bb729c · 2024-04-04T21:03:51.000-04:00
Co-authored-by: Oscar Esteban &lt;code@oscaresteban.es&gt;
diff --git a/templateflow/__init__.py b/templateflow/__init__.py
@@ -37,8 +37,8 @@
     del version
     del PackageNotFoundError
 
-from . import api
-from .conf import update
+from templateflow import api
+from templateflow.conf import update
 
 __all__ = [
     '__copyright__',
diff --git a/templateflow/conf/__init__.py b/templateflow/conf/__init__.py
@@ -31,7 +31,7 @@ def _env_to_bool(envvar: str, default: bool) -> bool:
                 f'Falling back to default value <{default}>'
             )
             return default
-    return val
+    return bool(val)
 
 
 TF_DEFAULT_HOME = Path.home() / '.cache' / 'templateflow'

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ def _env_to_bool(envvar: str, default: bool) -> bool:`
`31`	`31`	`f'Falling back to default value <{default}>'`
`32`	`32`	`)`
`33`	`33`	`return default`
`34`		`- return val`
	`34`	`+ return bool(val)`
`35`	`35`
`36`	`36`
`37`	`37`	`TF_DEFAULT_HOME = Path.home() / '.cache' / 'templateflow'`