sty: revise tests according to ruff

Author: oesteban

templateflow/conf/tests/test_conf.py

@@ -124,7 +124,7 @@ def test_layout_errors(monkeypatch):
     def myfunc():
         return 'okay'
 
-    def mock_import(name, globals=None, locals=None, fromlist=tuple(), level=0):
+    def mock_import(name, globals=None, locals=None, fromlist=(), level=0):  # noqa: A002
         if name == 'bids':
             raise ModuleNotFoundError
         return oldimport(name, globals=globals, locals=locals, fromlist=fromlist, level=level)

templateflow/conf/tests/test_s3.py

@@ -39,7 +39,7 @@ def test_get_skel_file(monkeypatch):
     assert Path(new_skel).stat().st_size > 0
 
     latest_md5 = (
-        requests.get(s3.TF_SKEL_URL(release='master', ext='md5', allow_redirects=True))
+        requests.get(s3.TF_SKEL_URL(release='master', ext='md5', allow_redirects=True), timeout=10)
         .content.decode()
         .split()[0]
     )

templateflow/tests/test_api.py

@@ -46,15 +46,13 @@ def _parse_bibtex(self):
 
         try:
             self.etype = re.search(r'@(\w+)', self.text).group(1)
-        except AttributeError:
-            raise TypeError(f'Invalid bibtex: {self.text}')
+        except AttributeError as err:
+            raise TypeError(f'Invalid bibtex: {self.text}') from err
         try:
             self.citekey = re.search(r'@[^{]*{([^,\s]+)', self.text).group(1)
-        except AttributeError:
-            raise TypeError(f'Invalid bibtex: {self.text}')
-        self.pairs = {
-            key: val for key, val in re.findall(r'(\w+)=(\{[^{}]+\})', self.text)
-        }
+        except AttributeError as err:
+            raise TypeError(f'Invalid bibtex: {self.text}') from err
+        self.pairs = dict(re.findall(r'(\w+)=(\{[^{}]+\})', self.text))
 
     def get(self, val):
         return self.pairs.get(val)
@@ -177,7 +175,7 @@ def assert_same(self, other):
 
 
 @pytest.mark.parametrize(
-    'template,urls,fbib,lbib',
+    ('template', 'urls', 'fbib', 'lbib'),
     [
         ('MNI152NLin2009cAsym', mni2009_urls, mni2009_fbib, mni2009_lbib),
         ('fsLR', fslr_urls, fslr_fbib, fslr_lbib),
@@ -207,8 +205,7 @@ def test_citations(tmp_path, template, urls, fbib, lbib):
             assert len(bibs) == 1
 
     else:
-        # no citations currently
-        assert False
+        pytest.fail('no citations currently')
 
 
 def test_pybids_magic_get():
@@ -224,4 +221,4 @@ def test_pybids_magic_get():
     # Existing layout.get_* should not be bubbled to the layout
     # (that means, raise an AttributeError instead of a BIDSEntityError)
     with pytest.raises(AttributeError):
-        api.get_fieldmap
+        _ = api.get_fieldmap