Skip to content

Commit 74439c7

Browse files
committed
Add LastCurrentTime to version info to tell if it ever became current (#692)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Add LastCurrentTime to version info to tell if it ever became current <!-- Tell your future self why have you made these changes --> **Why?** So that the controller can accelerate rollout if it detects that the target version was previously Current (aka it's actually a roll back) <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> Doesn't break server, but here's the server PR: temporalio/temporal#8845
1 parent 6b4f060 commit 74439c7

File tree

4 files changed

+73
-48
lines changed

4 files changed

+73
-48
lines changed

deployment/v1/message.pb.go

Lines changed: 70 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

temporalproto/openapi/openapiv2.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

temporalproto/openapi/openapiv3.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)