Skip to content

Commit 0d2638e

Browse files
authored
add WorkflowTaskFailedCause to RespondQueryTaskCompletedRequest (#602)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Adding a `cause` field to `RespondQueryTaskCompletedRequest` similar to `RespondWorkflowTaskFailedRequest`. <!-- Tell your future self why have you made these changes --> **Why?** Server needs a clean way to distinguish NDE and some other versioning-related errors for the dry-run API and user-experience insights. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** None at the moment.- SDK needs to send the info
1 parent 5771218 commit 0d2638e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -985,6 +985,9 @@ message RespondQueryTaskCompletedRequest {
985985
// traces.
986986
// Mutually exclusive with `query_result`. Set when the query fails.
987987
temporal.api.failure.v1.Failure failure = 7;
988+
// Why did the task fail? It's important to note that many of the variants in this enum cannot
989+
// apply to worker responses. See the type's doc for more.
990+
temporal.api.enums.v1.WorkflowTaskFailedCause cause = 8;
988991
}
989992

990993
message RespondQueryTaskCompletedResponse {

0 commit comments

Comments
 (0)