Skip to content

Commit 2bab1e0

Browse files
authored
Remove WorkerVersionStamp.deployment_series_name (#485)
* Add Deployment APIs * Move UpdateDeploymentMemo to deployment dir * Address feedback & rename deployment_name * Addressed comments * Addressed feedback * WIP git rid of stamp * Deprecate WorkerVersionStamp * Rename RedirectInfo to DeploymentTransition * undo enum comment change * regen files * Deprecate WorkerVersionStamp and replace it with Deployment * Deprecate WorkerVersionStamp and replace it with Deployment * Remove WorkerVersionStamp.deployment_series_name
1 parent ad41fcf commit 2bab1e0

File tree

4 files changed

+9
-24
lines changed

4 files changed

+9
-24
lines changed

openapi/openapiv2.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12379,13 +12379,9 @@
1237912379
"useVersioning": {
1238012380
"type": "boolean",
1238112381
"description": "If set, the worker is opting in to worker versioning. Otherwise, this is used only as a\nmarker for workflow reset points and the BuildIDs search attribute."
12382-
},
12383-
"deploymentSeriesName": {
12384-
"type": "string",
12385-
"description": "Must be sent if user has set a deployment series name (versioning-3).\nDeprecated. SDK should return `Deployment` in the requests to server instead of populating\nthis field."
1238612382
}
1238712383
},
12388-
"description": "Identifies the version of a worker that received or processed a task\nDeprecated. This message is replaced with `Deployment` and `VersioningBehavior`."
12384+
"title": "Deprecated. This message is replaced with `Deployment` and `VersioningBehavior`.\nIdentifies the version of a worker that received or processed a task"
1238912385
},
1239012386
"v1WorkflowExecution": {
1239112387
"type": "object",

openapi/openapiv3.yaml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9770,15 +9770,9 @@ components:
97709770
description: |-
97719771
If set, the worker is opting in to worker versioning. Otherwise, this is used only as a
97729772
marker for workflow reset points and the BuildIDs search attribute.
9773-
deploymentSeriesName:
9774-
type: string
9775-
description: |-
9776-
Must be sent if user has set a deployment series name (versioning-3).
9777-
Deprecated. SDK should return `Deployment` in the requests to server instead of populating
9778-
this field.
97799773
description: |-
9780-
Identifies the version of a worker that received or processed a task
9781-
Deprecated. This message is replaced with `Deployment` and `VersioningBehavior`.
9774+
Deprecated. This message is replaced with `Deployment` and `VersioningBehavior`.
9775+
Identifies the version of a worker that received or processed a task
97829776
WorkflowEvent_EventReference:
97839777
type: object
97849778
properties:

temporal/api/common/v1/message.proto

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ message MeteringMetadata {
123123
uint32 nonfirst_local_activity_execution_attempts = 13;
124124
}
125125

126-
// Identifies the version of a worker that received or processed a task
127126
// Deprecated. This message is replaced with `Deployment` and `VersioningBehavior`.
127+
// Identifies the version of a worker that received or processed a task
128128
message WorkerVersionStamp {
129129
// An opaque whole-worker identifier. Replaces the deprecated `binary_checksum` field when this
130130
// message is included in requests which previously used that.
@@ -134,11 +134,6 @@ message WorkerVersionStamp {
134134
// marker for workflow reset points and the BuildIDs search attribute.
135135
bool use_versioning = 3;
136136

137-
// Must be sent if user has set a deployment series name (versioning-3).
138-
// Deprecated. SDK should return `Deployment` in the requests to server instead of populating
139-
// this field.
140-
string deployment_series_name = 4;
141-
142137
// Later, may include bundle id that could be used for WASM and/or JS dynamically loadable bundles.
143138
}
144139

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ message RespondWorkflowTaskCompletedRequest {
352352
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
353353
// field to true. See message docstrings for more.
354354
// Deprecated. Use `deployment` and `versioning_behavior` instead.
355-
temporal.api.common.v1.WorkerVersionStamp worker_version_stamp = 10;
355+
temporal.api.common.v1.WorkerVersionStamp worker_version_stamp = 10 [deprecated = true];
356356
// Default versioning behavior that is set at worker server level.
357357
// Protocol messages piggybacking on a WFT as a transport
358358
repeated temporal.api.protocol.v1.Message messages = 11;
@@ -402,7 +402,7 @@ message RespondWorkflowTaskFailedRequest {
402402
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
403403
// field to true. See message docstrings for more.
404404
// Deprecated. Use `deployment` instead.
405-
temporal.api.common.v1.WorkerVersionStamp worker_version = 8;
405+
temporal.api.common.v1.WorkerVersionStamp worker_version = 8 [deprecated = true];
406406
// Deployment info of the worker that completed this task. Must be present if user has set
407407
// `WorkerDeploymentOptions` regardless of versioning being enabled or not.
408408
temporal.api.deployment.v1.Deployment deployment = 9;
@@ -519,7 +519,7 @@ message RespondActivityTaskCompletedRequest {
519519
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
520520
// field to true. See message docstrings for more.
521521
// Deprecated. Use `deployment` instead.
522-
temporal.api.common.v1.WorkerVersionStamp worker_version = 5;
522+
temporal.api.common.v1.WorkerVersionStamp worker_version = 5 [deprecated = true];
523523
// Deployment info of the worker that completed this task. Must be present if user has set
524524
// `WorkerDeploymentOptions` regardless of versioning being enabled or not.
525525
temporal.api.deployment.v1.Deployment deployment = 6;
@@ -560,7 +560,7 @@ message RespondActivityTaskFailedRequest {
560560
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
561561
// field to true. See message docstrings for more.
562562
// Deprecated. Use `deployment` instead.
563-
temporal.api.common.v1.WorkerVersionStamp worker_version = 6;
563+
temporal.api.common.v1.WorkerVersionStamp worker_version = 6 [deprecated = true];
564564
// Deployment info of the worker that completed this task. Must be present if user has set
565565
// `WorkerDeploymentOptions` regardless of versioning being enabled or not.
566566
temporal.api.deployment.v1.Deployment deployment = 7;
@@ -607,7 +607,7 @@ message RespondActivityTaskCanceledRequest {
607607
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
608608
// field to true. See message docstrings for more.
609609
// Deprecated. Use `deployment` instead.
610-
temporal.api.common.v1.WorkerVersionStamp worker_version = 5;
610+
temporal.api.common.v1.WorkerVersionStamp worker_version = 5 [deprecated = true];
611611
// Deployment info of the worker that completed this task. Must be present if user has set
612612
// `WorkerDeploymentOptions` regardless of versioning being enabled or not.
613613
temporal.api.deployment.v1.Deployment deployment = 6;

0 commit comments

Comments
 (0)