Commit 37b0602
authored
Worker heartbeat: Remove heartbeat from non-nexus polling (#633)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND
SDK teams before merging! This is why the number of required approvals
is "2" and not "1"--two reviewers from the same team is NOT sufficient.
If your PR is not approved by someone in BOTH teams, it may be summarily
reverted._
<!-- Describe what has changed in this PR -->
**What changed?**
Removed the `worker_heartbeat` field from non-nexus calls
<!-- Tell your future self why have you made these changes -->
**Why?**
We only want `worker_heartbeat` info sent on nexus polls, worker
shutdown, and dedicated worker heartbeat requests.
<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
Breaking change for a WIP feature, should have no effect. Also tried
grepping for this field in server and didn't find it used anywhere.
<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**1 parent e02a846 commit 37b0602
File tree
2 files changed
+1
-7
lines changed- temporal/api/workflowservice/v1
2 files changed
+1
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | 272 | | |
276 | 273 | | |
277 | 274 | | |
| |||
443 | 440 | | |
444 | 441 | | |
445 | 442 | | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | 443 | | |
451 | 444 | | |
452 | 445 | | |
| |||
0 commit comments