Skip to content

Commit 37b0602

Browse files
authored
Worker heartbeat: Remove heartbeat from non-nexus polling (#633)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Removed the `worker_heartbeat` field from non-nexus calls <!-- Tell your future self why have you made these changes --> **Why?** We only want `worker_heartbeat` info sent on nexus polls, worker shutdown, and dedicated worker heartbeat requests. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Breaking change for a WIP feature, should have no effect. Also tried grepping for this field in server and didn't find it used anywhere. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
1 parent e02a846 commit 37b0602

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

buf.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ breaking:
1414
ignore:
1515
- google
1616
# TODO (yuandrew): remove this. Added for "heartbeat" changes
17+
- temporal/api/workflowservice/v1/request_response.proto
1718
- temporal/api/worker/v1/message.proto
1819
lint:
1920
use:

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,6 @@ message PollWorkflowTaskQueueRequest {
269269
// Worker deployment options that user has set in the worker.
270270
// Experimental. Worker Deployments are experimental and might significantly change in the future.
271271
temporal.api.deployment.v1.WorkerDeploymentOptions deployment_options = 6;
272-
273-
// Worker info to be sent to the server.
274-
temporal.api.worker.v1.WorkerHeartbeat worker_heartbeat = 7;
275272
}
276273

277274
message PollWorkflowTaskQueueResponse {
@@ -443,10 +440,6 @@ message PollActivityTaskQueueRequest {
443440
temporal.api.common.v1.WorkerVersionCapabilities worker_version_capabilities = 5 [deprecated = true];
444441
// Worker deployment options that user has set in the worker.
445442
temporal.api.deployment.v1.WorkerDeploymentOptions deployment_options = 6;
446-
447-
// Worker info to be sent to the server.
448-
temporal.api.worker.v1.WorkerHeartbeat worker_heartbeat = 7;
449-
450443
}
451444

452445
message PollActivityTaskQueueResponse {

0 commit comments

Comments
 (0)