Commit 3f76376
authored
Fix protobuf syntax that is causing an error in protobufjs (#589)
**What changed?**
- Fix a double semicolon introduced in #579.
**Why?**
- The double semicolon sequence is causing a compilation error in
`protobufjs`, even though this is technically valid according to [the
official Protobuf 3
spec](https://protobuf.dev/reference/protobuf/proto3-spec/#emptystatement).
This is a bug in `protobufjs`, for which there's been [an open issue
ticket](protobufjs/protobuf.js#1322) since
2019, but it was never acknowledged, and a PR fixing this has been
ignored for more than a year.
Given that there's simply no reason to use a double semicolon sequence
anyway, it appears preferable to simply avoid that in our proto
definitions.1 parent ec8d4ef commit 3f76376
File tree
3 files changed
+9
-7
lines changed- openapi
- temporal/api/history/v1
3 files changed
+9
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15407 | 15407 | | |
15408 | 15408 | | |
15409 | 15409 | | |
15410 | | - | |
| 15410 | + | |
15411 | 15411 | | |
15412 | 15412 | | |
15413 | 15413 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12911 | 12911 | | |
12912 | 12912 | | |
12913 | 12913 | | |
12914 | | - | |
| 12914 | + | |
| 12915 | + | |
| 12916 | + | |
12915 | 12917 | | |
12916 | 12918 | | |
12917 | 12919 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
440 | 440 | | |
441 | 441 | | |
442 | 442 | | |
443 | | - | |
| 443 | + | |
444 | 444 | | |
445 | 445 | | |
446 | 446 | | |
| |||
475 | 475 | | |
476 | 476 | | |
477 | 477 | | |
478 | | - | |
479 | | - | |
| 478 | + | |
| 479 | + | |
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
| |||
509 | 509 | | |
510 | 510 | | |
511 | 511 | | |
512 | | - | |
| 512 | + | |
513 | 513 | | |
514 | 514 | | |
515 | 515 | | |
| |||
0 commit comments