Rename Decision to Command (#73)

Author: alexshtin

temporal/api/decision/v1/message.proto temporal/api/command/v1/message.prototemporal/api/decision/v1/message.proto renamed to temporal/api/command/v1/message.proto

@@ -22,20 +22,20 @@
 
 syntax = "proto3";
 
-package temporal.api.decision.v1;
+package temporal.api.command.v1;
 
-option go_package = "go.temporal.io/api/decision/v1;decision";
-option java_package = "io.temporal.api.decision.v1";
+option go_package = "go.temporal.io/api/command/v1;command";
+option java_package = "io.temporal.api.command.v1";
 option java_multiple_files = true;
 option java_outer_classname = "MessageProto";
 
 import "temporal/api/enums/v1/workflow.proto";
-import "temporal/api/enums/v1/decision_type.proto";
+import "temporal/api/enums/v1/command_type.proto";
 import "temporal/api/common/v1/message.proto";
 import "temporal/api/failure/v1/message.proto";
 import "temporal/api/taskqueue/v1/message.proto";
 
-message ScheduleActivityTaskDecisionAttributes {
+message ScheduleActivityTaskCommandAttributes {
     string activity_id = 1;
     temporal.api.common.v1.ActivityType activity_type = 2;
     string namespace = 3;
@@ -61,40 +61,40 @@ message ScheduleActivityTaskDecisionAttributes {
     temporal.api.common.v1.RetryPolicy retry_policy = 11;
 }
 
-message RequestCancelActivityTaskDecisionAttributes {
+message RequestCancelActivityTaskCommandAttributes {
     int64 scheduled_event_id = 1;
 }
 
-message StartTimerDecisionAttributes {
+message StartTimerCommandAttributes {
     string timer_id = 1;
     int64 start_to_fire_timeout_seconds = 2;
 }
 
-message CompleteWorkflowExecutionDecisionAttributes {
+message CompleteWorkflowExecutionCommandAttributes {
     temporal.api.common.v1.Payloads result = 1;
 }
 
-message FailWorkflowExecutionDecisionAttributes {
+message FailWorkflowExecutionCommandAttributes {
     temporal.api.failure.v1.Failure failure = 1;
 }
 
-message CancelTimerDecisionAttributes {
+message CancelTimerCommandAttributes {
     string timer_id = 1;
 }
 
-message CancelWorkflowExecutionDecisionAttributes {
+message CancelWorkflowExecutionCommandAttributes {
     temporal.api.common.v1.Payloads details = 1;
 }
 
-message RequestCancelExternalWorkflowExecutionDecisionAttributes {
+message RequestCancelExternalWorkflowExecutionCommandAttributes {
     string namespace = 1;
     string workflow_id = 2;
     string run_id = 3;
     string control = 4;
     bool child_workflow_only = 5;
 }
 
-message SignalExternalWorkflowExecutionDecisionAttributes {
+message SignalExternalWorkflowExecutionCommandAttributes {
     string namespace = 1;
     temporal.api.common.v1.WorkflowExecution execution = 2;
     string signal_name = 3;
@@ -103,25 +103,25 @@ message SignalExternalWorkflowExecutionDecisionAttributes {
     bool child_workflow_only = 6;
 }
 
-message UpsertWorkflowSearchAttributesDecisionAttributes {
+message UpsertWorkflowSearchAttributesCommandAttributes {
     temporal.api.common.v1.SearchAttributes search_attributes = 1;
 }
 
-message RecordMarkerDecisionAttributes {
+message RecordMarkerCommandAttributes {
     string marker_name = 1;
     map<string, temporal.api.common.v1.Payloads> details = 2;
     temporal.api.common.v1.Header header = 3;
     temporal.api.failure.v1.Failure failure = 4;
 }
 
-message ContinueAsNewWorkflowExecutionDecisionAttributes {
+message ContinueAsNewWorkflowExecutionCommandAttributes {
     temporal.api.common.v1.WorkflowType workflow_type = 1;
     temporal.api.taskqueue.v1.TaskQueue task_queue = 2;
     temporal.api.common.v1.Payloads input = 3;
-    // workflowExecutionTimeout is omitted as it shouldn'be overridden from within a workflow
-    // Timeout of a single workflow run
+    // workflow_execution_timeout is omitted as it shouldn'be overridden from within a workflow.
+    // Timeout of a single workflow run.
     int32 workflow_run_timeout_seconds = 4;
-    // Timeout of a single workflow task
+    // Timeout of a single workflow task.
     int32 workflow_task_timeout_seconds = 5;
     int32 backoff_start_interval_in_seconds = 6;
     temporal.api.common.v1.RetryPolicy retry_policy = 7;
@@ -134,17 +134,17 @@ message ContinueAsNewWorkflowExecutionDecisionAttributes {
     temporal.api.common.v1.SearchAttributes search_attributes = 14;
 }
 
-message StartChildWorkflowExecutionDecisionAttributes {
+message StartChildWorkflowExecutionCommandAttributes {
     string namespace = 1;
     string workflow_id = 2;
     temporal.api.common.v1.WorkflowType workflow_type = 3;
     temporal.api.taskqueue.v1.TaskQueue task_queue = 4;
     temporal.api.common.v1.Payloads input = 5;
-    // Total workflow execution timeout including retries and continue as new
+    // Total workflow execution timeout including retries and continue as new.
     int32 workflow_execution_timeout_seconds = 6;
-    // Timeout of a single workflow run
+    // Timeout of a single workflow run.
     int32 workflow_run_timeout_seconds = 7;
-    // Timeout of a single workflow task
+    // Timeout of a single workflow task.
     int32 workflow_task_timeout_seconds = 8;
     // Default: PARENT_CLOSE_POLICY_TERMINATE.
     temporal.api.enums.v1.ParentClosePolicy parent_close_policy = 9;
@@ -158,21 +158,21 @@ message StartChildWorkflowExecutionDecisionAttributes {
     temporal.api.common.v1.SearchAttributes search_attributes = 16;
 }
 
-message Decision {
-    temporal.api.enums.v1.DecisionType decision_type = 1;
+message Command {
+    temporal.api.enums.v1.CommandType command_type = 1;
     oneof attributes {
-        ScheduleActivityTaskDecisionAttributes schedule_activity_task_decision_attributes = 2;
-        StartTimerDecisionAttributes start_timer_decision_attributes = 3;
-        CompleteWorkflowExecutionDecisionAttributes complete_workflow_execution_decision_attributes = 4;
-        FailWorkflowExecutionDecisionAttributes fail_workflow_execution_decision_attributes = 5;
-        RequestCancelActivityTaskDecisionAttributes request_cancel_activity_task_decision_attributes = 6;
-        CancelTimerDecisionAttributes cancel_timer_decision_attributes = 7;
-        CancelWorkflowExecutionDecisionAttributes cancel_workflow_execution_decision_attributes = 8;
-        RequestCancelExternalWorkflowExecutionDecisionAttributes request_cancel_external_workflow_execution_decision_attributes = 9;
-        RecordMarkerDecisionAttributes record_marker_decision_attributes = 10;
-        ContinueAsNewWorkflowExecutionDecisionAttributes continue_as_new_workflow_execution_decision_attributes = 11;
-        StartChildWorkflowExecutionDecisionAttributes start_child_workflow_execution_decision_attributes = 12;
-        SignalExternalWorkflowExecutionDecisionAttributes signal_external_workflow_execution_decision_attributes = 13;
-        UpsertWorkflowSearchAttributesDecisionAttributes upsert_workflow_search_attributes_decision_attributes = 14;
+        ScheduleActivityTaskCommandAttributes schedule_activity_task_command_attributes = 2;
+        StartTimerCommandAttributes start_timer_command_attributes = 3;
+        CompleteWorkflowExecutionCommandAttributes complete_workflow_execution_command_attributes = 4;
+        FailWorkflowExecutionCommandAttributes fail_workflow_execution_command_attributes = 5;
+        RequestCancelActivityTaskCommandAttributes request_cancel_activity_task_command_attributes = 6;
+        CancelTimerCommandAttributes cancel_timer_command_attributes = 7;
+        CancelWorkflowExecutionCommandAttributes cancel_workflow_execution_command_attributes = 8;
+        RequestCancelExternalWorkflowExecutionCommandAttributes request_cancel_external_workflow_execution_command_attributes = 9;
+        RecordMarkerCommandAttributes record_marker_command_attributes = 10;
+        ContinueAsNewWorkflowExecutionCommandAttributes continue_as_new_workflow_execution_command_attributes = 11;
+        StartChildWorkflowExecutionCommandAttributes start_child_workflow_execution_command_attributes = 12;
+        SignalExternalWorkflowExecutionCommandAttributes signal_external_workflow_execution_command_attributes = 13;
+        UpsertWorkflowSearchAttributesCommandAttributes upsert_workflow_search_attributes_command_attributes = 14;
     }
 }

temporal/api/enums/v1/decision_type.proto temporal/api/enums/v1/command_type.prototemporal/api/enums/v1/decision_type.proto renamed to temporal/api/enums/v1/command_type.proto

@@ -27,22 +27,22 @@ package temporal.api.enums.v1;
 option go_package = "go.temporal.io/api/enums/v1;enums";
 option java_package = "io.temporal.api.enums.v1";
 option java_multiple_files = true;
-option java_outer_classname = "DecisionTypeProto";
+option java_outer_classname = "CommandTypeProto";
 
-// Whenever this list of decision is changed do change the function shouldBufferEvent in mutableStateBuilder.go to make sure to do the correct event ordering.
-enum DecisionType {
-    DECISION_TYPE_UNSPECIFIED = 0;
-    DECISION_TYPE_SCHEDULE_ACTIVITY_TASK = 1;
-    DECISION_TYPE_REQUEST_CANCEL_ACTIVITY_TASK = 2;
-    DECISION_TYPE_START_TIMER = 3;
-    DECISION_TYPE_COMPLETE_WORKFLOW_EXECUTION = 4;
-    DECISION_TYPE_FAIL_WORKFLOW_EXECUTION = 5;
-    DECISION_TYPE_CANCEL_TIMER = 6;
-    DECISION_TYPE_CANCEL_WORKFLOW_EXECUTION = 7;
-    DECISION_TYPE_REQUEST_CANCEL_EXTERNAL_WORKFLOW_EXECUTION = 8;
-    DECISION_TYPE_RECORD_MARKER = 9;
-    DECISION_TYPE_CONTINUE_AS_NEW_WORKFLOW_EXECUTION = 10;
-    DECISION_TYPE_START_CHILD_WORKFLOW_EXECUTION = 11;
-    DECISION_TYPE_SIGNAL_EXTERNAL_WORKFLOW_EXECUTION = 12;
-    DECISION_TYPE_UPSERT_WORKFLOW_SEARCH_ATTRIBUTES = 13;
+// Whenever this list of command types is changed do change the function shouldBufferEvent in mutableStateBuilder.go to make sure to do the correct event ordering.
+enum CommandType {
+    COMMAND_TYPE_UNSPECIFIED = 0;
+    COMMAND_TYPE_SCHEDULE_ACTIVITY_TASK = 1;
+    COMMAND_TYPE_REQUEST_CANCEL_ACTIVITY_TASK = 2;
+    COMMAND_TYPE_START_TIMER = 3;
+    COMMAND_TYPE_COMPLETE_WORKFLOW_EXECUTION = 4;
+    COMMAND_TYPE_FAIL_WORKFLOW_EXECUTION = 5;
+    COMMAND_TYPE_CANCEL_TIMER = 6;
+    COMMAND_TYPE_CANCEL_WORKFLOW_EXECUTION = 7;
+    COMMAND_TYPE_REQUEST_CANCEL_EXTERNAL_WORKFLOW_EXECUTION = 8;
+    COMMAND_TYPE_RECORD_MARKER = 9;
+    COMMAND_TYPE_CONTINUE_AS_NEW_WORKFLOW_EXECUTION = 10;
+    COMMAND_TYPE_START_CHILD_WORKFLOW_EXECUTION = 11;
+    COMMAND_TYPE_SIGNAL_EXTERNAL_WORKFLOW_EXECUTION = 12;
+    COMMAND_TYPE_UPSERT_WORKFLOW_SEARCH_ATTRIBUTES = 13;
 }

temporal/api/enums/v1/failed_cause.proto

@@ -31,7 +31,7 @@ option java_outer_classname = "FailedCauseProto";
 
 enum WorkflowTaskFailedCause {
     WORKFLOW_TASK_FAILED_CAUSE_UNSPECIFIED = 0;
-    WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_DECISION = 1;
+    WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND = 1;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_SCHEDULE_ACTIVITY_ATTRIBUTES = 2;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_REQUEST_CANCEL_ACTIVITY_ATTRIBUTES = 3;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_START_TIMER_ATTRIBUTES = 4;
@@ -47,8 +47,8 @@ enum WorkflowTaskFailedCause {
     WORKFLOW_TASK_FAILED_CAUSE_WORKFLOW_WORKER_UNHANDLED_FAILURE = 14;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_SIGNAL_WORKFLOW_EXECUTION_ATTRIBUTES = 15;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_START_CHILD_EXECUTION_ATTRIBUTES = 16;
-    WORKFLOW_TASK_FAILED_CAUSE_FORCE_CLOSE_DECISION = 17;
-    WORKFLOW_TASK_FAILED_CAUSE_FAILOVER_CLOSE_DECISION = 18;
+    WORKFLOW_TASK_FAILED_CAUSE_FORCE_CLOSE_COMMAND = 17;
+    WORKFLOW_TASK_FAILED_CAUSE_FAILOVER_CLOSE_COMMAND = 18;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_SIGNAL_INPUT_SIZE = 19;
     WORKFLOW_TASK_FAILED_CAUSE_RESET_WORKFLOW = 20;
     WORKFLOW_TASK_FAILED_CAUSE_BAD_BINARY = 21;

temporal/api/workflow/v1/message.proto

@@ -89,7 +89,7 @@ message ResetPoints {
 message ResetPointInfo {
     string binary_checksum = 1;
     string run_id = 2;
-    int64 first_decision_completed_id = 3;
+    int64 first_workflow_task_completed_id = 3;
     int64 create_time_nano = 4;
     // The time that the run is deleted due to retention.
     int64 expire_time_nano = 5;

temporal/api/workflowservice/v1/request_response.proto

@@ -38,7 +38,7 @@ import "temporal/api/enums/v1/task_queue.proto";
 import "temporal/api/common/v1/message.proto";
 import "temporal/api/history/v1/message.proto";
 import "temporal/api/workflow/v1/message.proto";
-import "temporal/api/decision/v1/message.proto";
+import "temporal/api/command/v1/message.proto";
 import "temporal/api/failure/v1/message.proto";
 import "temporal/api/filter/v1/message.proto";
 import "temporal/api/namespace/v1/message.proto";
@@ -194,7 +194,7 @@ message PollWorkflowTaskQueueResponse {
 
 message RespondWorkflowTaskCompletedRequest {
     bytes task_token = 1;
-    repeated temporal.api.decision.v1.Decision decisions = 2;
+    repeated temporal.api.command.v1.Command commands = 2;
     string identity = 3;
     temporal.api.taskqueue.v1.StickyExecutionAttributes sticky_attributes = 4;
     bool return_new_workflow_task = 5;
@@ -396,7 +396,7 @@ message ResetWorkflowExecutionRequest {
     string namespace = 1;
     temporal.api.common.v1.WorkflowExecution workflow_execution = 2;
     string reason = 3;
-    int64 decision_finish_event_id = 4;
+    int64 workflow_task_finish_event_id = 4;
     string request_id = 5;
 }