Skip to content

Commit 496da20

Browse files
authored
Remove query consistency level from request (#55)
1 parent 4888bc3 commit 496da20

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ GOPATH := $(shell go env GOPATH)
88
endif
99

1010
PROTO_ROOT := .
11-
PROTO_DIRS = $(shell find $(PROTO_ROOT) -name "*.proto" -printf "%h\n" | sort -u)
11+
PROTO_DIRS = $(sort $(dir $(shell find $(PROTO_ROOT) -name "*.proto")))
1212
PROTO_OUT := .gen
1313
PROTO_IMPORT := $(PROTO_ROOT):$(GOPATH)/src/github.com/temporalio/gogo-protobuf/protobuf
1414

@@ -25,11 +25,11 @@ grpc: gogo-grpc fix-path
2525

2626
go-grpc: clean $(PROTO_OUT)
2727
echo "Compiling for go-gRPC..."
28-
$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --proto_path=$(PROTO_IMPORT) --go_out=plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)/*.proto;)
28+
$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --proto_path=$(PROTO_IMPORT) --go_out=plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)*.proto;)
2929

3030
gogo-grpc: clean $(PROTO_OUT)
3131
echo "Compiling for gogo-gRPC..."
32-
$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --proto_path=$(PROTO_IMPORT) --gogoslick_out=Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)/*.proto;)
32+
$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --proto_path=$(PROTO_IMPORT) --gogoslick_out=Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)*.proto;)
3333

3434
fix-path:
3535
mv -f $(PROTO_OUT)/temporal/* $(PROTO_OUT) && rm -d $(PROTO_OUT)/temporal

temporal/version/v1/message.proto

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,13 @@ option java_package = "io.temporal.proto.version.v1";
2929
option java_multiple_files = true;
3030
option java_outer_classname = "MessageProto";
3131

32-
// TODO: Rename to SupportedSDKVersions
33-
// SupportedClientVersions contains the support versions for SDK.
34-
message SupportedClientVersions{
32+
// SupportedSDKVersions contains the support versions for SDK.
33+
message SupportedSDKVersions{
3534
string go_sdk = 1;
3635
string java_sdk = 2;
3736
}
3837

3938
message WorkerVersionInfo {
40-
// TODO: implementation
41-
string impl = 1;
39+
string implementation = 1;
4240
string feature_version = 2;
4341
}

temporal/workflowservice/v1/request_response.proto

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,6 @@ message QueryWorkflowRequest {
513513
temporal.query.v1.WorkflowQuery query = 3;
514514
// QueryRejectCondition can used to reject the query if workflow state does not satisfy condition
515515
temporal.enums.v1.QueryRejectCondition query_reject_condition = 4;
516-
temporal.enums.v1.QueryConsistencyLevel query_consistency_level = 5;
517516
}
518517

519518
message QueryWorkflowResponse {
@@ -550,7 +549,7 @@ message GetClusterInfoRequest {
550549

551550
// GetClusterInfoResponse contains information about Temporal cluster
552551
message GetClusterInfoResponse {
553-
temporal.version.v1.SupportedClientVersions supported_client_versions = 1;
552+
temporal.version.v1.SupportedSDKVersions supported_sdk_versions = 1;
554553
}
555554

556555
message ListTaskListPartitionsRequest {

0 commit comments

Comments
 (0)