Skip to content

Commit 52b8544

Browse files
authored
add client identity to update-metadata request (#600)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> add client identity to update-metadata request <!-- Tell your future self why have you made these changes --> on the server side we generate a uuid identity. would be nice to allow user to specify it instead <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
1 parent babf177 commit 52b8544

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

openapi/openapiv2.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8275,6 +8275,10 @@
82758275
"type": "string"
82768276
},
82778277
"description": "List of keys to remove from the metadata."
8278+
},
8279+
"identity": {
8280+
"type": "string",
8281+
"description": "Optional. The identity of the client who initiated this request."
82788282
}
82798283
},
82808284
"description": "Used to update the user-defined metadata of a Worker Deployment Version."

openapi/openapiv3.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11968,6 +11968,9 @@ components:
1196811968
items:
1196911969
type: string
1197011970
description: List of keys to remove from the metadata.
11971+
identity:
11972+
type: string
11973+
description: Optional. The identity of the client who initiated this request.
1197111974
description: Used to update the user-defined metadata of a Worker Deployment Version.
1197211975
UpdateWorkerDeploymentVersionMetadataResponse:
1197311976
type: object

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2229,6 +2229,8 @@ message UpdateWorkerDeploymentVersionMetadataRequest {
22292229
map<string, temporal.api.common.v1.Payload> upsert_entries = 3;
22302230
// List of keys to remove from the metadata.
22312231
repeated string remove_entries = 4;
2232+
// Optional. The identity of the client who initiated this request.
2233+
string identity = 6;
22322234
}
22332235

22342236
message UpdateWorkerDeploymentVersionMetadataResponse {

0 commit comments

Comments
 (0)