Skip to content

Commit 575dadb

Browse files
hai719cretz
andauthored
Reserve RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST (#502)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Reserve RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST option. <!-- Tell your future self why have you made these changes --> **Why?** Cancel request should be reapplied only in conflict resolution case. There is no option to exclude it for reset. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** --------- Co-authored-by: Chad Retz <[email protected]>
1 parent bae790a commit 575dadb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

openapi/openapiv2.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10864,7 +10864,7 @@
1086410864
"RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST"
1086510865
],
1086610866
"default": "RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
10867-
"description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST: Exclude cancel request events when reapplying events beyond the reset point."
10867+
"description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST: Deprecated, unimplemented option."
1086810868
},
1086910869
"v1ResetReapplyType": {
1087010870
"type": "string",

temporal/api/enums/v1/reset.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ enum ResetReapplyExcludeType {
4040
RESET_REAPPLY_EXCLUDE_TYPE_UPDATE = 2;
4141
// Exclude nexus events when reapplying events beyond the reset point.
4242
RESET_REAPPLY_EXCLUDE_TYPE_NEXUS = 3;
43-
// Exclude cancel request events when reapplying events beyond the reset point.
44-
RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST = 4;
43+
// Deprecated, unimplemented option.
44+
RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST = 4 [deprecated=true];
4545
}
4646

4747
// Event types to include when reapplying events. Deprecated: applications

0 commit comments

Comments
 (0)