Skip to content

Commit 8ab82a6

Browse files
hai719cretz
andauthored
Provide option to exclude cancel request events from being reapplied beyond reset point (#493)
<!-- Describe what has changed in this PR --> Added a new option RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST that the operator could choose to disable reapplying of cancel request events beyond the reset point. <!-- Tell your future self why have you made these changes --> **Why?** We are adding cancellation reapply to conflict resolution and workflow reset. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** --------- Co-authored-by: Chad Retz <[email protected]>
1 parent e91e73a commit 8ab82a6

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

openapi/openapiv2.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10071,10 +10071,11 @@
1007110071
"RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
1007210072
"RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL",
1007310073
"RESET_REAPPLY_EXCLUDE_TYPE_UPDATE",
10074-
"RESET_REAPPLY_EXCLUDE_TYPE_NEXUS"
10074+
"RESET_REAPPLY_EXCLUDE_TYPE_NEXUS",
10075+
"RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST"
1007510076
],
1007610077
"default": "RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
10077-
"description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point."
10078+
"description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST: Exclude cancel request events when reapplying events beyond the reset point."
1007810079
},
1007910080
"v1ResetReapplyType": {
1008010081
"type": "string",

openapi/openapiv3.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7467,6 +7467,7 @@ components:
74677467
- RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL
74687468
- RESET_REAPPLY_EXCLUDE_TYPE_UPDATE
74697469
- RESET_REAPPLY_EXCLUDE_TYPE_NEXUS
7470+
- RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST
74707471
type: string
74717472
format: enum
74727473
description: Event types not to be reapplied
@@ -7553,6 +7554,7 @@ components:
75537554
- RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL
75547555
- RESET_REAPPLY_EXCLUDE_TYPE_UPDATE
75557556
- RESET_REAPPLY_EXCLUDE_TYPE_NEXUS
7557+
- RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST
75567558
type: string
75577559
format: enum
75587560
description: Event types not to be reapplied

temporal/api/enums/v1/reset.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ enum ResetReapplyExcludeType {
4040
RESET_REAPPLY_EXCLUDE_TYPE_UPDATE = 2;
4141
// Exclude nexus events when reapplying events beyond the reset point.
4242
RESET_REAPPLY_EXCLUDE_TYPE_NEXUS = 3;
43+
// Exclude cancel request events when reapplying events beyond the reset point.
44+
RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST = 4;
4345
}
4446

4547
// Event types to include when reapplying events. Deprecated: applications

0 commit comments

Comments
 (0)