Skip to content

Commit a6a28b9

Browse files
bergundydandavison
andcommitted
Apply suggestions from code review
Co-authored-by: Dan Davison <[email protected]>
1 parent 9ce001e commit a6a28b9

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

openapi/openapiv2.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10363,11 +10363,11 @@
1036310363
},
1036410364
"scheduleToStartTimeout": {
1036510365
"type": "string",
10366-
"description": "Limits time an activity task can stay in a task queue before a worker picks it up. This\ntimeout is always non retryable, as all a retry would achieve is to put it back into the same\nqueue. Defaults to `schedule_to_close_timeout` or workflow execution timeout if not\nspecified.\n"
10366+
"description": "Limits time an activity task can stay in a task queue before a worker picks it up. This\ntimeout is always non retryable, as all a retry would achieve is to put it back into the same\nqueue. Defaults to `schedule_to_close_timeout`.\n"
1036710367
},
1036810368
"startToCloseTimeout": {
1036910369
"type": "string",
10370-
"description": "Maximum time an activity is allowed to execute after being picked up by a worker. This\ntimeout is always retryable.\n"
10370+
"description": "Maximum time a single activity attempt is allowed to execute after being picked up by a worker. This\ntimeout is always retryable.\n"
1037110371
},
1037210372
"heartbeatTimeout": {
1037310373
"type": "string",

openapi/openapiv3.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7273,16 +7273,15 @@ components:
72737273
description: |-
72747274
Limits time an activity task can stay in a task queue before a worker picks it up. This
72757275
timeout is always non retryable, as all a retry would achieve is to put it back into the same
7276-
queue. Defaults to `schedule_to_close_timeout` or workflow execution timeout if not
7277-
specified.
7276+
queue. Defaults to `schedule_to_close_timeout`.
72787277

72797278
(-- api-linter: core::0140::prepositions=disabled
72807279
aip.dev/not-precedent: "to" is used to indicate interval. --)
72817280
startToCloseTimeout:
72827281
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
72837282
type: string
72847283
description: |-
7285-
Maximum time an activity is allowed to execute after being picked up by a worker. This
7284+
Maximum time a single activity attempt is allowed to execute after being picked up by a worker. This
72867285
timeout is always retryable.
72877286

72887287
(-- api-linter: core::0140::prepositions=disabled

temporal/api/activity/v1/message.proto

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,12 @@ message ActivityExecutionInfo {
7777
google.protobuf.Duration schedule_to_close_timeout = 7;
7878
// Limits time an activity task can stay in a task queue before a worker picks it up. This
7979
// timeout is always non retryable, as all a retry would achieve is to put it back into the same
80-
// queue. Defaults to `schedule_to_close_timeout` or workflow execution timeout if not
81-
// specified.
80+
// queue. Defaults to `schedule_to_close_timeout`.
8281
//
8382
// (-- api-linter: core::0140::prepositions=disabled
8483
// aip.dev/not-precedent: "to" is used to indicate interval. --)
8584
google.protobuf.Duration schedule_to_start_timeout = 8;
86-
// Maximum time an activity is allowed to execute after being picked up by a worker. This
85+
// Maximum time a single activity attempt is allowed to execute after being picked up by a worker. This
8786
// timeout is always retryable.
8887
//
8988
// (-- api-linter: core::0140::prepositions=disabled

0 commit comments

Comments
 (0)