Skip to content

Commit b2ed381

Browse files
committed
Address review comments from #675
1 parent a13f2a9 commit b2ed381

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

temporal/api/activity/v1/message.proto

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ message ActivityExecutionInfo {
6767
// More detailed breakdown of ACTIVITY_EXECUTION_STATUS_RUNNING.
6868
temporal.api.enums.v1.PendingActivityState run_state = 5;
6969

70-
temporal.api.taskqueue.v1.TaskQueue task_queue = 6;
70+
string task_queue = 6;
7171

7272
// Indicates how long the caller is willing to wait for an activity completion. Limits how long
7373
// retries will be attempted.
@@ -105,9 +105,10 @@ message ActivityExecutionInfo {
105105
// Incremented each time a new attempt is started.
106106
// TODO(dandavison): Confirm if this is on scheduled or started.
107107
int32 attempt = 15;
108-
int32 maximum_attempts = 16;
108+
// How long this activity has been running for, including all attempts and backoff between attempts.
109+
google.protobuf.Duration execution_duration = 16;
109110
// Time the activity was originally scheduled via a StartActivityExecution request.
110-
google.protobuf.Timestamp scheduled_time = 17;
111+
google.protobuf.Timestamp schedule_time = 17;
111112
// Scheduled time + schedule to close timeout.
112113
google.protobuf.Timestamp expiration_time = 18;
113114
// Time when the activity transitioned to a closed state.
@@ -166,9 +167,7 @@ message ActivityExecutionListInfo {
166167
// The type of the activity, a string that maps to a registered activity on a worker.
167168
temporal.api.common.v1.ActivityType activity_type = 3;
168169
// Time the activity was originally scheduled via a StartActivityExecution request.
169-
// TODO: Workflows call this schedule_time but it's scheduled_time in PendingActivityInfo, what should we choose for
170-
// consistency?
171-
google.protobuf.Timestamp scheduled_time = 4;
170+
google.protobuf.Timestamp schedule_time = 4;
172171
// If the activity is in a terminal status, this field represents the time the activity transitioned to that status.
173172
google.protobuf.Timestamp close_time = 5;
174173
// Only scheduled and terminal statuses appear here. More detailed information in PendingActivityInfo but not

0 commit comments

Comments
 (0)