Re-enable protobuf breaking change detection (#116)

Author: wxing1292

.buildkite/Dockerfile

@@ -1,9 +1,2 @@
-FROM golang:1.15.6
-
-RUN apt update && apt install -y --no-install-recommends \
-      protobuf-compiler \
-      && rm -rf /var/lib/apt/lists/* \
-# https://github.com/docker-library/golang/blob/c1baf037d71331eb0b8d4c70cff4c29cf124c5e0/1.4/Dockerfile
-      && mkdir -p /temporal
-
-WORKDIR /temporal
+FROM temporalio/base-ci-builder:1.0.0
+WORKDIR /temporal

.buildkite/pipeline.yml

@@ -3,7 +3,7 @@ steps:
     agents:
       queue: "default"
       docker: "*"
-    command: "make"
+    command: "make ci-build"
     plugins:
       - docker-compose#v3.1.0:
           run: build

Makefile

@@ -1,7 +1,9 @@
 $(VERBOSE).SILENT:
 ############################# Main targets #############################
-# Install everything, run all linters, and compile proto files.
-install: grpc-install api-linter-install buf-install proto
+ci-build: install proto
+
+# Install dependencies.
+install: grpc-install api-linter-install buf-install
 
 # Run all linters and compile proto files.
 proto: grpc
@@ -43,21 +45,21 @@ fix-path:
 ##### Plugins & tools #####
 grpc-install: gogo-protobuf-install
 	printf $(COLOR) "Install/update gRPC plugins..."
-	GO111MODULE=on go get google.golang.org/grpc@v1.34.0
+	go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1.0
 
 gogo-protobuf-install: go-protobuf-install
-	go get github.com/temporalio/gogo-protobuf/protoc-gen-gogoslick
+	GO111MODULE=off go get github.com/temporalio/gogo-protobuf/protoc-gen-gogoslick
 
 go-protobuf-install:
-	GO111MODULE=on go get github.com/golang/protobuf/[email protected]
+	go install github.com/golang/protobuf/[email protected]
 
 api-linter-install:
 	printf $(COLOR) "Install/update api-linter..."
-	GO111MODULE=on go get github.com/googleapis/api-linter/cmd/api-linter@v1.10.0
+	go install github.com/googleapis/api-linter/cmd/api-linter@v1.22.0
 
 buf-install:
 	printf $(COLOR) "Install/update buf..."
-	GO111MODULE=on go get github.com/bufbuild/buf/cmd/buf@v0.33.0
+	go install github.com/bufbuild/buf/cmd/buf@v0.43.2
 
 ##### Linters #####
 api-linter:
@@ -66,10 +68,11 @@ api-linter:
 
 buf-lint:
 	printf $(COLOR) "Run buf linter..."
-	(cd $(PROTO_ROOT) && buf check lint)
+	(cd $(PROTO_ROOT) && buf lint)
 
 buf-breaking:
-	@printf $(COLOR) "Run buf breaking changes check against master branch..."
+	@printf $(COLOR) "Run buf breaking changes check against master branch..."	
+	@(cd $(PROTO_ROOT) && buf breaking --against '.git#branch=master')
 
 ##### Clean #####
 clean: