Skip to content

Commit d674607

Browse files
authored
Add identity to workflow update-options (#656)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> Ddd identity to workflow update-options <!-- Tell your future self why have you made these changes --> So that the history event can serve as an audit log as to who set versioning overrides on the workflow <!-- Are there any breaking changes on binary or code level? --> None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> temporalio/temporal#8576
1 parent 663d63d commit d674607

File tree

4 files changed

+19
-0
lines changed

4 files changed

+19
-0
lines changed

openapi/openapiv2.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9206,6 +9206,10 @@
92069206
"updateMask": {
92079207
"type": "string",
92089208
"description": "Controls which fields from `workflow_execution_options` will be applied.\nTo unset a field, set it to null and use the update mask to indicate that it should be mutated."
9209+
},
9210+
"identity": {
9211+
"type": "string",
9212+
"description": "Optional. The identity of the client who initiated this request."
92099213
}
92109214
},
92119215
"description": "Keep the parameters in sync with:\n - temporal.api.batch.v1.BatchOperationUpdateWorkflowExecutionOptions.\n - temporal.api.workflow.v1.PostResetOperation.UpdateWorkflowOptions."
@@ -16800,6 +16804,10 @@
1680016804
"$ref": "#/definitions/v1Callback"
1680116805
},
1680216806
"description": "Completion callbacks attached to the running workflow execution."
16807+
},
16808+
"identity": {
16809+
"type": "string",
16810+
"description": "Optional. The identity of the client who initiated the request that created this event."
1680316811
}
1680416812
}
1680516813
},

openapi/openapiv3.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13044,6 +13044,9 @@ components:
1304413044
Controls which fields from `workflow_execution_options` will be applied.
1304513045
To unset a field, set it to null and use the update mask to indicate that it should be mutated.
1304613046
format: field-mask
13047+
identity:
13048+
type: string
13049+
description: Optional. The identity of the client who initiated this request.
1304713050
description: |-
1304813051
Keep the parameters in sync with:
1304913052
- temporal.api.batch.v1.BatchOperationUpdateWorkflowExecutionOptions.
@@ -14249,6 +14252,9 @@ components:
1424914252
items:
1425014253
$ref: '#/components/schemas/Callback'
1425114254
description: Completion callbacks attached to the running workflow execution.
14255+
identity:
14256+
type: string
14257+
description: Optional. The identity of the client who initiated the request that created this event.
1425214258
WorkflowExecutionSignaledEventAttributes:
1425314259
type: object
1425414260
properties:

temporal/api/history/v1/message.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,8 @@ message WorkflowExecutionOptionsUpdatedEventAttributes {
797797
string attached_request_id = 3;
798798
// Completion callbacks attached to the running workflow execution.
799799
repeated temporal.api.common.v1.Callback attached_completion_callbacks = 4;
800+
// Optional. The identity of the client who initiated the request that created this event.
801+
string identity = 5;
800802
}
801803

802804
// Not used anywhere. Use case is replaced by WorkflowExecutionOptionsUpdatedEventAttributes

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,6 +2036,9 @@ message UpdateWorkflowExecutionOptionsRequest {
20362036
// Controls which fields from `workflow_execution_options` will be applied.
20372037
// To unset a field, set it to null and use the update mask to indicate that it should be mutated.
20382038
google.protobuf.FieldMask update_mask = 4;
2039+
2040+
// Optional. The identity of the client who initiated this request.
2041+
string identity = 5;
20392042
}
20402043

20412044
message UpdateWorkflowExecutionOptionsResponse {

0 commit comments

Comments
 (0)