-
Notifications
You must be signed in to change notification settings - Fork 430
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
Currently the ttlSecondsAfterFinished spec is hard coded to 86400. It would be ideal if not only you could change this value, but you could remove it altogether.
This is especially important if you use Argo for deployment. Eventually the after-finished controller kicks in and then the job disappears. Argo then reports that there is something missing in that particular application until its synced again.
Describe the solution you'd like
This should be easily achievable by adding some key value pairs in the values file and key off of those in the job template.
values.yaml:
schema:
garbageCollection:
# Enable or disable the job garbage collection
enabled: true
# Time before the job is removed in seconds Default 86400
ttlSeconds: 86400
templates/server-job.yaml
existing:
spec:
backoffLimit: {{ $.Values.schema.setup.backoffLimit }}
ttlSecondsAfterFinished: 86400
updated:
spec:
backoffLimit: {{ $.Values.schema.setup.backoffLimit }}
{{- if and $.Values.schema.garbageCollection $.Values.schema.garbageCollection.enabled }}
ttlSecondsAfterFinished: {{ $.Values.schema.garbageCollection.ttlSeconds | default 86400 }}
{{- end }}
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request