[Bug] TEMPORAL_ADDRESS cannot be overwritten in temporal-web deployment

[bzanardo]

What are you really trying to do?

Overwrite the TEMPORAL_ADDRESS in the temporal-web deployment to point to the internal-frontend service.

Describe the bug

In the web-deployment.yaml template in version 1.0.0-rc.2 of the helm chart, the TEMPORAL_ADDRESS environment variable is hard coded:

containers:
        - name: {{ .Chart.Name }}-web
          image: "{{ .Values.web.image.repository }}:{{ .Values.web.image.tag }}"
          imagePullPolicy: {{ .Values.web.image.pullPolicy }}
          env:
            - name: TEMPORAL_ADDRESS
              value: "{{ include "temporal.fullname" $ }}-frontend.{{ .Release.Namespace }}.svc:{{ .Values.server.frontend.service.port }}"
          {{- if .Values.web.additionalEnv }}
          {{- toYaml .Values.web.additionalEnv | nindent 12 }}
          {{- end }}

Which causes a duplicate TEMPORAL_ADDRESS environment variable when the variable is set in the values.yaml file.

Minimal Reproduction

Set TEMPORAL_ADDRESS in the values.yaml:

temporal:
  web:
    additionalEnv:
      - name: TEMPORAL_ADDRESS
        value: "sample_address"

Render the chart using helm template. The TEMPORAL_ADDRESS env var will be set twice in the temporal-web deployment.

Environment/Versions

• OS and processor: [e.g. M1 Mac, x86 Windows, Linux] M4 Mac
• Temporal Version: [e.g. 1.14.0?] and/or SDK version: 1.0.0-rc.2
• Are you using Docker or Kubernetes or building Temporal from source? Kubernetes

Additional context