cleanup tests

Author: donald-pinckney

tests/openai_agents/basic/test_agent_lifecycle_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 
@@ -18,7 +17,6 @@ async def test_execute_workflow(client: Client):
         task_queue=task_queue_name,
         workflows=[AgentLifecycleWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed - workflow uses function tools
     ):
         result = await client.execute_workflow(
             AgentLifecycleWorkflow.run,
@@ -28,7 +26,6 @@ async def test_execute_workflow(client: Client):
         )
 
         # Verify the result has the expected structure
-        assert hasattr(result, "number")
         assert isinstance(result.number, int)
         assert (
             0 <= result.number <= 20

tests/openai_agents/basic/test_dynamic_system_prompt_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 
@@ -18,7 +17,6 @@ async def test_execute_workflow_with_random_style(client: Client):
         task_queue=task_queue_name,
         workflows=[DynamicSystemPromptWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed
     ):
         result = await client.execute_workflow(
             DynamicSystemPromptWorkflow.run,
@@ -41,7 +39,6 @@ async def test_execute_workflow_with_specific_style(client: Client):
         task_queue=task_queue_name,
         workflows=[DynamicSystemPromptWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed
     ):
         result = await client.execute_workflow(
             DynamicSystemPromptWorkflow.run,

tests/openai_agents/basic/test_hello_world_workflow.py

@@ -1,17 +1,9 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
-from temporalio import activity
 from temporalio.client import Client
 from temporalio.worker import Worker
 
-from openai_agents.basic.activities.get_weather_activity import get_weather
-from openai_agents.basic.activities.image_activities import read_image_as_base64
-from openai_agents.basic.activities.math_activities import (
-    multiply_by_two,
-    random_number,
-)
 from openai_agents.basic.workflows.hello_world_workflow import HelloWorldAgent
 
 
@@ -23,16 +15,12 @@ async def test_execute_workflow(client: Client):
         task_queue=task_queue_name,
         workflows=[HelloWorldAgent],
         activity_executor=ThreadPoolExecutor(5),
-        activities=[
-            get_weather,
-            multiply_by_two,
-            random_number,
-            read_image_as_base64,
-        ],
     ):
-        await client.execute_workflow(
+        result = await client.execute_workflow(
             HelloWorldAgent.run,
             "Write a recursive haiku about recursive haikus.",
             id=str(uuid.uuid4()),
             task_queue=task_queue_name,
         )
+        assert isinstance(result, str)
+        assert len(result) > 0

tests/openai_agents/basic/test_lifecycle_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 
@@ -16,7 +15,6 @@ async def test_execute_workflow(client: Client):
         task_queue=task_queue_name,
         workflows=[LifecycleWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed - workflow uses function tools
     ):
         result = await client.execute_workflow(
             LifecycleWorkflow.run,
@@ -26,7 +24,6 @@ async def test_execute_workflow(client: Client):
         )
 
         # Verify the result has the expected structure
-        assert hasattr(result, "number")
         assert isinstance(result.number, int)
         assert (
             0 <= result.number <= 20

tests/openai_agents/basic/test_local_image_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 

tests/openai_agents/basic/test_non_strict_output_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 
@@ -30,17 +29,14 @@ async def test_execute_workflow(client: Client):
         # Verify the result has the expected structure
         assert isinstance(result, dict)
 
-        # Should have either strict_result or strict_error
-        assert "strict_result" in result or "strict_error" in result
-
-        # Should have either non_strict_result or non_strict_error
-        assert "non_strict_result" in result or "non_strict_error" in result
+        assert "strict_error" in result
+        assert "non_strict_result" in result
 
         # If there's a strict_error, it should be a string
         if "strict_error" in result:
             assert isinstance(result["strict_error"], str)
             assert len(result["strict_error"]) > 0
 
-        # If there's a non_strict_result, verify it's valid
-        if "non_strict_result" in result:
-            assert result["non_strict_result"] is not None
+        jokes = result["non_strict_result"]["jokes"]
+        assert isinstance(jokes, dict)
+        assert isinstance(jokes[list(jokes.keys())[0]], str)

tests/openai_agents/basic/test_previous_response_id_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 
@@ -18,7 +17,6 @@ async def test_execute_workflow(client: Client):
         task_queue=task_queue_name,
         workflows=[PreviousResponseIdWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed
     ):
         first_question = "What is the capital of France?"
         follow_up_question = "What is the population of that city?"

tests/openai_agents/basic/test_remote_image_workflow.py

@@ -1,14 +1,12 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker
 
 from openai_agents.basic.workflows.remote_image_workflow import RemoteImageWorkflow
 
 
-# TODO(@donald-pinckney): debug this test
 async def test_execute_workflow_default_question(client: Client):
     task_queue_name = str(uuid.uuid4())
 
@@ -17,9 +15,7 @@ async def test_execute_workflow_default_question(client: Client):
         task_queue=task_queue_name,
         workflows=[RemoteImageWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed - uses remote URL directly
     ):
-        # Using a reliable test image URL
         test_image_url = "https://upload.wikimedia.org/wikipedia/commons/0/0c/GoldenGateBridge-001.jpg"
 
         result = await client.execute_workflow(
@@ -34,7 +30,6 @@ async def test_execute_workflow_default_question(client: Client):
         assert len(result) > 0
 
 
-# TODO(@donald-pinckney): debug this test
 async def test_execute_workflow_custom_question(client: Client):
     task_queue_name = str(uuid.uuid4())
 
@@ -43,9 +38,7 @@ async def test_execute_workflow_custom_question(client: Client):
         task_queue=task_queue_name,
         workflows=[RemoteImageWorkflow],
         activity_executor=ThreadPoolExecutor(5),
-        # No external activities needed - uses remote URL directly
     ):
-        # Using a reliable test image URL
         test_image_url = "https://upload.wikimedia.org/wikipedia/commons/0/0c/GoldenGateBridge-001.jpg"
         custom_question = "What do you see in this image?"
 

tests/openai_agents/basic/test_tools_workflow.py

@@ -1,7 +1,6 @@
 import uuid
 from concurrent.futures import ThreadPoolExecutor
 
-import pytest
 from temporalio.client import Client
 from temporalio.worker import Worker