Use hashset to dedupe plugin names from Lang (#1072)

* Use hashset to dedupe

* Ensure plugins are sent in deterministic, sorted order

Author: yuandrew

crates/common/src/worker.rs

@@ -238,7 +238,7 @@ pub struct WorkerConfig {
 
     /// List of plugins used by lang.
     #[builder(default)]
-    pub plugins: Vec<PluginInfo>,
+    pub plugins: HashSet<PluginInfo>,
 
     /// Skips the single worker+client+namespace+task_queue check
     #[builder(default = "false")]

crates/sdk-core-c-bridge/src/worker.rs

@@ -1262,13 +1262,15 @@ impl TryFrom<&WorkerOptions> for temporalio_sdk_core::WorkerConfig {
                 opt.plugins
                     .to_str_vec()
                     .into_iter()
+                    .collect::<HashSet<_>>()
+                    .into_iter()
                     .map(
                         |name| temporalio_common::protos::temporal::api::worker::v1::PluginInfo {
                             name: name.to_owned(),
                             version: String::new(),
                         },
                     )
-                    .collect::<Vec<_>>(),
+                    .collect::<HashSet<_>>(),
             )
             .build()
             .map_err(|err| anyhow::anyhow!(err))

crates/sdk-core/src/worker/mod.rs

@@ -1190,6 +1190,9 @@ impl WorkerHeartbeatManager {
                 }
             });
 
+            let mut plugins: Vec<_> = config.plugins.clone().into_iter().collect();
+            plugins.sort_by(|a, b| a.name.cmp(&b.name));
+
             let mut worker_heartbeat = WorkerHeartbeat {
                 worker_instance_key: worker_instance_key.to_string(),
                 host_info: Some(WorkerHostInfo {
@@ -1208,7 +1211,7 @@ impl WorkerHeartbeatManager {
 
                 status: (*heartbeat_manager_metrics.status.read()) as i32,
                 start_time,
-                plugins: config.plugins.clone(),
+                plugins,
 
                 // Some Metrics dependent fields are set below, and
                 // some fields like sdk_name, sdk_version, and worker_identity, must be set by

crates/sdk-core/tests/integ_tests/worker_heartbeat_tests.rs

@@ -136,16 +136,20 @@ async fn docker_worker_heartbeat_basic(#[values("otel", "prom", "no_metrics")] b
         .max_outstanding_workflow_tasks(5_usize)
         .max_cached_workflows(5_usize)
         .max_outstanding_activities(5_usize)
-        .plugins(vec![
-            PluginInfo {
-                name: "plugin1".to_string(),
-                version: "1".to_string(),
-            },
-            PluginInfo {
-                name: "plugin2".to_string(),
-                version: "2".to_string(),
-            },
-        ]);
+        .plugins(
+            [
+                PluginInfo {
+                    name: "plugin1".to_string(),
+                    version: "1".to_string(),
+                },
+                PluginInfo {
+                    name: "plugin2".to_string(),
+                    version: "2".to_string(),
+                },
+            ]
+            .into_iter()
+            .collect::<HashSet<_>>(),
+        );
     let mut worker = starter.worker().await;
     let worker_instance_key = worker.worker_instance_key();