Switched to Rust 1.90 in CI (#1024)

Author: maciejdudko

.github/workflows/heavy.yml

@@ -19,6 +19,8 @@ jobs:
         with:
           submodules: recursive
       - uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:

.github/workflows/per-pr.yml

@@ -21,7 +21,7 @@ jobs:
           submodules: recursive
       - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: 1.88.0
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:
@@ -58,7 +58,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: 1.88.0
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:
@@ -106,7 +106,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: 1.88.0
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:
@@ -139,7 +139,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: 1.88.0
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:
@@ -164,7 +164,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: 1.88.0
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:
@@ -185,7 +185,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: 1.88.0
+          toolchain: 1.90.0
       - name: Install protoc
         uses: arduino/setup-protoc@v3
         with:

core/src/internal_flags.rs

@@ -18,6 +18,7 @@ use temporal_sdk_core_protos::temporal::api::{
 /// may be removed from the enum. *Importantly*, all variants must be given explicit values, such
 /// that removing older variants does not create any change in existing values. Removed flag
 /// variants must be reserved forever (a-la protobuf), and should be called out in a comment.
+#[allow(unreachable_pub)] // re-exported in test_help::integ_helpers
 #[repr(u32)]
 #[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Copy, Clone, Debug, enum_iterator::Sequence)]
 pub enum CoreInternalFlags {

core/src/worker/mod.rs

@@ -18,6 +18,8 @@ pub(crate) use activities::{
     NewLocalAct,
 };
 pub(crate) use wft_poller::WFTPollerShared;
+
+#[allow(unreachable_pub)] // re-exported in test_help::integ_helpers
 pub use workflow::LEGACY_QUERY_ID;
 
 use crate::{

core/src/worker/workflow/mod.rs

@@ -99,6 +99,7 @@ use tracing::Span;
 /// Id used by server for "legacy" queries. IE: Queries that come in the `query` rather than
 /// `queries` field of a WFT, and are responded to on the separate `respond_query_task_completed`
 /// rpc.
+#[allow(unreachable_pub)] // re-exported in supermodule
 pub const LEGACY_QUERY_ID: &str = "legacy_query";
 /// What percentage of a WFT timeout we are willing to wait before sending a WFT heartbeat when
 /// necessary.

fsm/rustfsm_procmacro/tests/trybuild/dupe_transitions_fail.stderr

@@ -1,11 +1,11 @@
 error: Duplicate transitions are not allowed!
   --> $DIR/dupe_transitions_fail.rs:5:1
    |
-5  | / fsm! {
-6  | |     name SimpleMachine; command SimpleMachineCommand; error Infallible;
-7  | |
-8  | |     One --(A)--> Two;
-9  | |     One --(A)--> Two;
+ 5 | / fsm! {
+ 6 | |     name SimpleMachine; command SimpleMachineCommand; error Infallible;
+ 7 | |
+ 8 | |     One --(A)--> Two;
+ 9 | |     One --(A)--> Two;
 10 | | }
    | |_^
    |