Skip to content

Commit a2e1f34

Browse files
committed
Fix codec tests
1 parent 18e7bcc commit a2e1f34

File tree

4 files changed

+22
-4
lines changed

4 files changed

+22
-4
lines changed

src/Temporalio/Worker/WorkflowCodecHelper.cs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,10 @@ await EncodeAsync(
157157
case WorkflowCommand.VariantOneofCase.ScheduleActivity:
158158
await EncodeAsync(codec, cmd.ScheduleActivity.Arguments).ConfigureAwait(false);
159159
await EncodeAsync(codec, cmd.ScheduleActivity.Headers).ConfigureAwait(false);
160+
if (cmd.ScheduleActivity.Summary != null)
161+
{
162+
await EncodeAsync(codec, cmd.ScheduleActivity.Summary).ConfigureAwait(false);
163+
}
160164
break;
161165
case WorkflowCommand.VariantOneofCase.ScheduleLocalActivity:
162166
await EncodeAsync(
@@ -177,6 +181,19 @@ await EncodeAsync(
177181
codec, cmd.StartChildWorkflowExecution.Memo).ConfigureAwait(false);
178182
await EncodeAsync(
179183
codec, cmd.StartChildWorkflowExecution.Headers).ConfigureAwait(false);
184+
if (cmd.StartChildWorkflowExecution.StaticDetails != null)
185+
{
186+
await EncodeAsync(
187+
codec, cmd.StartChildWorkflowExecution.StaticDetails).ConfigureAwait(false);
188+
}
189+
if (cmd.StartChildWorkflowExecution.StaticSummary != null)
190+
{
191+
await EncodeAsync(
192+
codec, cmd.StartChildWorkflowExecution.StaticSummary).ConfigureAwait(false);
193+
}
194+
break;
195+
case WorkflowCommand.VariantOneofCase.StartTimer:
196+
await EncodeAsync(codec, cmd.StartTimer.Summary).ConfigureAwait(false);
180197
break;
181198
case WorkflowCommand.VariantOneofCase.UpdateResponse:
182199
if (cmd.UpdateResponse.Completed is { } updateCompleted)

src/Temporalio/Worker/WorkflowInstance.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1732,6 +1732,7 @@ public override Task DelayAsync(DelayAsyncInput input)
17321732
{
17331733
Seq = seq,
17341734
StartToFireTimeout = Google.Protobuf.WellKnownTypes.Duration.FromTimeSpan(delay),
1735+
Summary = instance.PayloadConverter.ToPayload(string.Empty),
17351736
},
17361737
});
17371738
}
@@ -2377,4 +2378,4 @@ public record Handler(
23772378
HandlerUnfinishedPolicy UnfinishedPolicy);
23782379
}
23792380
}
2380-
}
2381+
}

src/Temporalio/Workflows/ActivityOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,4 @@ public class ActivityOptions : ICloneable
105105
/// <returns>A shallow copy of these options.</returns>
106106
public virtual object Clone() => MemberwiseClone();
107107
}
108-
}
108+
}

tests/Temporalio.Tests/Worker/WorkflowCodecHelperTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ await CreateAndVisitPayload(
3131
return Task.CompletedTask;
3232
});
3333
// Confirm some known paths are there for fixed field, repeated, and map
34-
Assert.Contains("Jobs.StartWorkflow.Headers", paths);
34+
Assert.Contains("Jobs.InitializeWorkflow.Headers", paths);
3535
Assert.Contains("Jobs.SignalWorkflow.Input", paths);
3636
Assert.Contains("Jobs.ResolveActivity.Result.Completed.Result", paths);
3737
}
@@ -169,4 +169,4 @@ public Task<IReadOnlyCollection<Payload>> DecodeAsync(IReadOnlyCollection<Payloa
169169
return newP;
170170
}).ToList());
171171
}
172-
}
172+
}

0 commit comments

Comments
 (0)