Explicitly disallowing Nexus custom slot supplier

maciejdudko · maciejdudko · commit d45dd7ab9ece · 2025-10-08T11:50:34.000-04:00
diff --git a/src/Temporalio/Bridge/OptionsExtensions.cs b/src/Temporalio/Bridge/OptionsExtensions.cs
@@ -661,6 +661,12 @@ private static Interop.TemporalCoreTunerHolder ToInteropTuner(
                 }
             }
 
+            // TODO: remove when implemented: https://github.com/temporalio/sdk-dotnet/issues/528
+            if (tuner.NexusTaskSlotSupplier is Temporalio.Worker.Tuning.CustomSlotSupplier)
+            {
+                throw new ArgumentException("Custom Nexus task slot suppliers are unsupported");
+            }
+
             return new()
             {
                 workflow_slot_supplier =
diff --git a/tests/Temporalio.Tests/Worker/WorkerTuningTests.cs b/tests/Temporalio.Tests/Worker/WorkerTuningTests.cs
@@ -215,7 +215,8 @@ public async Task CanRunWith_CustomSlotSupplier()
             Client,
             new TemporalWorkerOptions($"tq-{Guid.NewGuid()}")
             {
-                Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, mySlotSupplier),
+                // TODO: change Nexus to custom slot supplier after it's implemented: https://github.com/temporalio/sdk-dotnet/issues/528
+                Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, new FixedSizeSlotSupplier(10)),
             }.AddWorkflow<SimpleWorkflow>().AddActivity(SimpleWorkflow.SomeActivity));
         await worker.ExecuteAsync(async () =>
         {
@@ -268,7 +269,8 @@ public async Task CanRunWith_ThrowingSlotSupplier()
             Client,
             new TemporalWorkerOptions($"tq-{Guid.NewGuid()}")
             {
-                Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, mySlotSupplier),
+                // TODO: change Nexus to custom slot supplier after it's implemented: https://github.com/temporalio/sdk-dotnet/issues/528
+                Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, new FixedSizeSlotSupplier(10)),
             }.AddWorkflow<OneTaskWf>());
         await worker.ExecuteAsync(async () =>
         {
@@ -309,7 +311,8 @@ public async Task CanRunWith_BlockingSlotSupplier()
             Client,
             new TemporalWorkerOptions($"tq-{Guid.NewGuid()}")
             {
-                Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, mySlotSupplier),
+                // TODO: change Nexus to custom slot supplier after it's implemented: https://github.com/temporalio/sdk-dotnet/issues/528
+                Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, new FixedSizeSlotSupplier(10)),
             }.AddWorkflow<OneTaskWf>());
         await worker.ExecuteAsync(async () =>
         {

Original file line number	Diff line number	Diff line change
`@@ -661,6 +661,12 @@ private static Interop.TemporalCoreTunerHolder ToInteropTuner(`
`661`	`661`	`}`
`662`	`662`	`}`
`663`	`663`
	`664`	`+ // TODO: remove when implemented: https://github.com/temporalio/sdk-dotnet/issues/528`
	`665`	`+ if (tuner.NexusTaskSlotSupplier is Temporalio.Worker.Tuning.CustomSlotSupplier)`
	`666`	`+ {`
	`667`	`+ throw new ArgumentException("Custom Nexus task slot suppliers are unsupported");`
	`668`	`+ }`
	`669`	`+`
`664`	`670`	`return new()`
`665`	`671`	`{`
`666`	`672`	`workflow_slot_supplier =`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,8 @@ public async Task CanRunWith_CustomSlotSupplier()`
`215`	`215`	`Client,`
`216`	`216`	`new TemporalWorkerOptions($"tq-{Guid.NewGuid()}")`
`217`	`217`	`{`
`218`		`- Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, mySlotSupplier),`
	`218`	`+ // TODO: change Nexus to custom slot supplier after it's implemented: https://github.com/temporalio/sdk-dotnet/issues/528`
	`219`	`+ Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, new FixedSizeSlotSupplier(10)),`
`219`	`220`	`}.AddWorkflow<SimpleWorkflow>().AddActivity(SimpleWorkflow.SomeActivity));`
`220`	`221`	`await worker.ExecuteAsync(async () =>`
`221`	`222`	`{`
`@@ -268,7 +269,8 @@ public async Task CanRunWith_ThrowingSlotSupplier()`
`268`	`269`	`Client,`
`269`	`270`	`new TemporalWorkerOptions($"tq-{Guid.NewGuid()}")`
`270`	`271`	`{`
`271`		`- Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, mySlotSupplier),`
	`272`	`+ // TODO: change Nexus to custom slot supplier after it's implemented: https://github.com/temporalio/sdk-dotnet/issues/528`
	`273`	`+ Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, new FixedSizeSlotSupplier(10)),`
`272`	`274`	`}.AddWorkflow<OneTaskWf>());`
`273`	`275`	`await worker.ExecuteAsync(async () =>`
`274`	`276`	`{`
`@@ -309,7 +311,8 @@ public async Task CanRunWith_BlockingSlotSupplier()`
`309`	`311`	`Client,`
`310`	`312`	`new TemporalWorkerOptions($"tq-{Guid.NewGuid()}")`
`311`	`313`	`{`
`312`		`- Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, mySlotSupplier),`
	`314`	`+ // TODO: change Nexus to custom slot supplier after it's implemented: https://github.com/temporalio/sdk-dotnet/issues/528`
	`315`	`+ Tuner = new WorkerTuner(mySlotSupplier, mySlotSupplier, mySlotSupplier, new FixedSizeSlotSupplier(10)),`
`313`	`316`	`}.AddWorkflow<OneTaskWf>());`
`314`	`317`	`await worker.ExecuteAsync(async () =>`
`315`	`318`	`{`