Unblock using conflict policy UseExisting for Nexus WorkflowRunOperation (#1858)

Author: rodrigozhou

internal/cmd/build/main.go

@@ -140,10 +140,6 @@ func (b *builder) integrationTest() error {
 	// Start dev server if wanted
 	if *devServerFlag {
 		devServer, err := testsuite.StartDevServer(context.Background(), testsuite.DevServerOptions{
-			// TODO: Use stable release once server 1.27.0 is out.
-			CachedDownload: testsuite.CachedDownload{
-				Version: "v1.3.0-rc.0",
-			},
 			ClientOptions: &client.Options{
 				HostPort:  "127.0.0.1:7233",
 				Namespace: "integration-test-namespace",

temporalnexus/operation.go

@@ -389,15 +389,6 @@ func ExecuteUntypedWorkflow[R any](
 	internal.SetLinksOnStartWorkflowOptions(&startWorkflowOptions, links)
 	internal.SetOnConflictOptionsOnStartWorkflowOptions(&startWorkflowOptions)
 
-	// TODO(rodrigozhou): temporarily blocking conflict policy UseExisting.
-	if startWorkflowOptions.WorkflowIDConflictPolicy == enums.WORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING {
-		return nil, &nexus.HandlerError{
-			Type:          nexus.HandlerErrorTypeInternal,
-			RetryBehavior: nexus.HandlerErrorRetryBehaviorNonRetryable,
-			Cause:         errors.New("workflow ID conflict policy UseExisting is not supported for Nexus WorkflowRunOperation"),
-		}
-	}
-
 	// This makes sure that ExecuteWorkflow will respect the WorkflowIDConflictPolicy, ie., if the
 	// conflict policy is to fail (default value), then ExecuteWorkflow will return an error if the
 	// workflow already running. For Nexus, this ensures that operation has only started successfully

test/nexus_test.go

@@ -1082,11 +1082,9 @@ func TestAsyncOperationFromWorkflow_MultipleCallers(t *testing.T) {
 		{
 			input: "conflict-policy-use-existing",
 			checkOutput: func(t *testing.T, numCalls int, res CallerWfOutput, err error) {
-				// TODO(rodrigozhou): assert NotError and remove the comments below after UseExisting is
-				// unblocked.
-				require.ErrorContains(t, err, "workflow ID conflict policy UseExisting is not supported for Nexus WorkflowRunOperation")
-				// require.EqualValues(t, numCalls, res.CntOk)
-				// require.EqualValues(t, 0, res.CntErr)
+				require.NoError(t, err)
+				require.EqualValues(t, numCalls, res.CntOk)
+				require.EqualValues(t, 0, res.CntErr)
 			},
 		},
 	}
@@ -1779,11 +1777,9 @@ func TestWorkflowTestSuite_WorkflowRunOperation_MultipleCallers(t *testing.T) {
 		{
 			input: "conflict-policy-use-existing",
 			checkOutput: func(t *testing.T, numCalls int, res CallerWfOutput, err error) {
-				// TODO(rodrigozhou): assert NotError and remove the comments below after UseExisting is
-				// unblocked.
-				require.ErrorContains(t, err, "workflow ID conflict policy UseExisting is not supported for Nexus WorkflowRunOperation")
-				// require.EqualValues(t, numCalls, res.CntOk)
-				// require.EqualValues(t, 0, res.CntErr)
+				require.NoError(t, err)
+				require.EqualValues(t, numCalls, res.CntOk)
+				require.EqualValues(t, 0, res.CntErr)
 			},
 		},
 	}