Skip to content

Commit 448f264

Browse files
Fix workflow start delay docs to say signal does not interrupt delay (#2190)
Fix start delay docs
1 parent 7229a45 commit 448f264

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,10 +374,8 @@ public Builder setDisableEagerExecution(boolean disableEagerExecution) {
374374
}
375375

376376
/**
377-
* Time to wait before dispatching the first workflow task. If the workflow gets a signal before
378-
* the delay, a workflow task will be dispatched and the rest of the delay will be ignored. A
379-
* signal from signal with start will not trigger a workflow task. Cannot be set the same time
380-
* as a CronSchedule.
377+
* Time to wait before dispatching the first workflow task. A signal from signal with start will
378+
* not trigger a workflow task. Cannot be set the same time as a CronSchedule.
381379
*/
382380
public Builder setStartDelay(Duration startDelay) {
383381
this.startDelay = startDelay;

temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowWorkerTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,11 +182,6 @@ public void concurrentPollRequestLockTest() throws Exception {
182182
});
183183

184184
assertTrue(worker.start());
185-
// All slots should be available
186-
reporter.assertGauge(
187-
MetricsType.WORKER_TASK_SLOTS_AVAILABLE,
188-
ImmutableMap.of("worker_type", "WorkflowWorker"),
189-
100.0);
190185
// Unblock the first poll
191186
blockFirstPollLatch.countDown();
192187
// Wait until we have got all the polls

0 commit comments

Comments
 (0)