Skip to content

Commit bf392f5

Browse files
authored
Bump some GHA actions back due to glibc compatibility (#2096)
1 parent 265590d commit bf392f5

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

.github/workflows/prepare-release.yml

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,12 @@ jobs:
137137
os_family: windows
138138
arch: amd64
139139
runs-on: ${{ matrix.runner }}
140+
env:
141+
# This is required to allow continuing usage of Node 16 for actions,
142+
# as Node 20 won't run on the builder we use for linux builds
143+
# (Node 20 require glibc 2.28+, but ubuntu-1804 has glibc 2.27).
144+
# https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/
145+
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
140146
steps:
141147
- name: Checkout repo
142148
uses: actions/checkout@v4
@@ -149,21 +155,24 @@ jobs:
149155
run: git tag "$INPUT_TAG"
150156

151157
- name: Set up Java
152-
uses: actions/setup-java@v4
158+
# FIXME: v4+ requires Node 20
159+
uses: actions/setup-java@v3
153160
with:
154161
java-version: "11"
155162
distribution: "temurin"
156163

157164
- name: Set up Gradle
158-
uses: gradle/actions/setup-gradle@v3
159-
165+
# FIXME: v3+ requires Node 20
166+
uses: gradle/gradle-build-action@v2
167+
160168
- name: Build native test server
161169
run: ./gradlew :temporal-test-server:build
162170

163171
# path ends in a wildcard because on windows the file ends in '.exe'
164172
# path excludes *.txt because native-image also writes a build manifest txt file
165173
- name: Upload executable to workflow
166-
uses: actions/upload-artifact@v4
174+
# FIXME: v4+ requires Node 20
175+
uses: actions/upload-artifact@v3
167176
with:
168177
name: ${{ matrix.os_family }}_${{ matrix.arch }}
169178
path: |
@@ -182,7 +191,8 @@ jobs:
182191

183192
# when no artifact is specified, all artifacts are downloaded and expanded into CWD
184193
- name: Fetch executables
185-
uses: actions/download-artifact@v4
194+
# Need v3 here to stay compatible with the build_native_images job.
195+
uses: actions/download-artifact@v3-node20
186196

187197
# example: linux_amd64/ -> temporal-test-server_1.2.3_linux_amd64
188198
# the name of the directory created becomes the basename of the archive (*.tar.gz or *.zip) and

0 commit comments

Comments
 (0)