Add support for update to the Java test server (#1762)

Add update support to test server

Author: Quinn-With-Two-Ns

temporal-sdk/src/test/java/io/temporal/client/functional/UpdateTest.java

@@ -20,16 +20,18 @@
 
 package io.temporal.client.functional;
 
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertThrows;
 
 import io.temporal.api.common.v1.WorkflowExecution;
 import io.temporal.client.*;
 import io.temporal.testing.internal.SDKTestOptions;
 import io.temporal.testing.internal.SDKTestWorkflowRule;
+import io.temporal.workflow.CompletablePromise;
+import io.temporal.workflow.Workflow;
 import io.temporal.workflow.shared.TestWorkflows;
 import java.util.concurrent.ExecutionException;
 import org.junit.Assume;
-import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 
@@ -38,16 +40,11 @@ public class UpdateTest {
   @Rule
   public SDKTestWorkflowRule testWorkflowRule =
       SDKTestWorkflowRule.newBuilder()
-          .setWorkflowTypes(UpdateTest.QuickWorkflowWithUpdateImpl.class)
+          .setWorkflowTypes(
+              UpdateTest.QuickWorkflowWithUpdateImpl.class,
+              UpdateTest.LongWorkflowWithUpdateImpl.class)
           .build();
 
-  @Before
-  public void checkExternalService() {
-    Assume.assumeTrue(
-        "skipping because test server does not support update",
-        testWorkflowRule.isUseExternalService());
-  }
-
   @Test
   public void updateNonExistentWorkflow() {
 
@@ -102,6 +99,44 @@ public void updateCompletedWorkflowUntyped() {
     assertThrows(ExecutionException.class, () -> updateRef.getResultAsync().get());
   }
 
+  @Test
+  public void updateWorkflowDuplicateId() {
+    Assume.assumeTrue(
+        "skipping for real server because the real server does not handle duplicate update ID correctly",
+        !testWorkflowRule.isUseExternalService());
+
+    WorkflowClient workflowClient = testWorkflowRule.getWorkflowClient();
+    String workflowType = TestWorkflows.WorkflowWithUpdate.class.getSimpleName();
+    WorkflowStub workflowStub =
+        workflowClient.newUntypedWorkflowStub(
+            workflowType,
+            SDKTestOptions.newWorkflowOptionsWithTimeouts(testWorkflowRule.getTaskQueue()));
+
+    WorkflowExecution execution = workflowStub.start();
+    SDKTestWorkflowRule.waitForOKQuery(workflowStub);
+
+    assertEquals(
+        "some-value",
+        workflowStub.update(
+            "update",
+            "update-id",
+            execution.getRunId(),
+            String.class,
+            String.class,
+            0,
+            "some-value"));
+    testWorkflowRule.waitForTheEndOfWFT(execution.getWorkflowId());
+    // Try to send another update request with the same update Id
+    assertEquals(
+        "some-value",
+        workflowStub.update(
+            "update", "update-id", "", String.class, String.class, 1, "some-other-value"));
+
+    workflowStub.update("complete", void.class);
+
+    workflowStub.getResult(String.class);
+  }
+
   public static class QuickWorkflowWithUpdateImpl implements TestWorkflows.TestUpdatedWorkflow {
 
     @Override
@@ -112,4 +147,35 @@ public String execute() {
     @Override
     public void update(String arg) {}
   }
+
+  public static class LongWorkflowWithUpdateImpl implements TestWorkflows.WorkflowWithUpdate {
+    CompletablePromise<Void> promise = Workflow.newPromise();
+
+    @Override
+    public String execute() {
+      promise.get();
+      return "complete";
+    }
+
+    @Override
+    public String getState() {
+      return "running";
+    }
+
+    @Override
+    public String update(Integer index, String value) {
+      return value;
+    }
+
+    @Override
+    public void updateValidator(Integer index, String value) {}
+
+    @Override
+    public void complete() {
+      promise.complete(null);
+    }
+
+    @Override
+    public void completeValidator() {}
+  }
 }

temporal-sdk/src/test/java/io/temporal/workflow/updateTest/UpdateRetryException.java

@@ -35,7 +35,6 @@
 import java.util.*;
 import java.util.concurrent.atomic.AtomicInteger;
 import org.junit.Assert;
-import org.junit.Assume;
 import org.junit.Rule;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -56,10 +55,6 @@ public class UpdateRetryException {
 
   @Test
   public void testUpdateExceptionRetries() {
-    Assume.assumeTrue(
-        "skipping for test server because test server does not support update",
-        testWorkflowRule.isUseExternalService());
-
     String workflowId = UUID.randomUUID().toString();
     WorkflowClient workflowClient = testWorkflowRule.getWorkflowClient();
     WorkflowOptions options =

temporal-sdk/src/test/java/io/temporal/workflow/updateTest/UpdateTest.java

@@ -40,7 +40,6 @@
 import java.util.Optional;
 import java.util.UUID;
 import java.util.concurrent.ExecutionException;
-import org.junit.Assume;
 import org.junit.Rule;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -60,10 +59,6 @@ public class UpdateTest {
 
   @Test
   public void testUpdate() {
-    Assume.assumeTrue(
-        "skipping for test server because test server does not support update",
-        testWorkflowRule.isUseExternalService());
-
     String workflowId = UUID.randomUUID().toString();
     WorkflowClient workflowClient = testWorkflowRule.getWorkflowClient();
     WorkflowOptions options =
@@ -105,10 +100,6 @@ public void testUpdate() {
 
   @Test
   public void testUpdateUntyped() throws ExecutionException, InterruptedException {
-    Assume.assumeTrue(
-        "skipping for test server because test server does not support update",
-        testWorkflowRule.isUseExternalService());
-
     WorkflowClient workflowClient = testWorkflowRule.getWorkflowClient();
     String workflowType = TestWorkflows.WorkflowWithUpdate.class.getSimpleName();
     WorkflowStub workflowStub =

temporal-sdk/src/test/java/io/temporal/workflow/updateTest/UpdateWithLocalActivity.java

@@ -36,7 +36,6 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.UUID;
-import org.junit.Assume;
 import org.junit.Rule;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -58,10 +57,6 @@ public class UpdateWithLocalActivity {
 
   @Test
   public void testUpdateWithLocalActivities() {
-    Assume.assumeTrue(
-        "skipping for test server because test server does not support update",
-        testWorkflowRule.isUseExternalService());
-
     String workflowId = UUID.randomUUID().toString();
     WorkflowClient workflowClient = testWorkflowRule.getWorkflowClient();
     WorkflowOptions options =

temporal-sdk/src/test/java/io/temporal/workflow/updateTest/UpdateWithSignalAndQuery.java

@@ -33,7 +33,6 @@
 import io.temporal.workflow.shared.TestActivities;
 import io.temporal.workflow.shared.TestWorkflows;
 import java.util.*;
-import org.junit.Assume;
 import org.junit.Rule;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -52,10 +51,6 @@ public class UpdateWithSignalAndQuery {
 
   @Test
   public void testUpdateWithSignal() {
-    Assume.assumeTrue(
-        "skipping for test server because test server does not support update",
-        testWorkflowRule.isUseExternalService());
-
     String workflowId = UUID.randomUUID().toString();
     WorkflowClient workflowClient = testWorkflowRule.getWorkflowClient();
     WorkflowOptions options =