Skip to content

Commit ad49032

Browse files
committed
Fix psalm issues
1 parent a3c2ace commit ad49032

File tree

3 files changed

+31
-1
lines changed

3 files changed

+31
-1
lines changed

psalm-baseline.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
<file src="src/Client/WorkflowClient.php">
124124
<ArgumentTypeCoercion>
125125
<code><![CDATA[$counter]]></code>
126+
<code><![CDATA[$signal]]></code>
126127
<code><![CDATA[$workflowType]]></code>
127128
<code><![CDATA[$workflowType]]></code>
128129
</ArgumentTypeCoercion>
@@ -148,13 +149,24 @@
148149
<LessSpecificReturnStatement>
149150
<code><![CDATA[new self($serviceClient, $options, $converter, $interceptorProvider)]]></code>
150151
</LessSpecificReturnStatement>
152+
<MissingParamType>
153+
<code><![CDATA[$workflow]]></code>
154+
</MissingParamType>
151155
<MoreSpecificReturnType>
152156
<code><![CDATA[static]]></code>
153157
</MoreSpecificReturnType>
154158
<RedundantFunctionCall>
155159
<code><![CDATA[\sprintf]]></code>
156160
<code><![CDATA[\sprintf]]></code>
157161
</RedundantFunctionCall>
162+
<TypeDoesNotContainType>
163+
<code><![CDATA[$signal === '']]></code>
164+
</TypeDoesNotContainType>
165+
</file>
166+
<file src="src/Client/WorkflowClientInterface.php">
167+
<MissingParamType>
168+
<code><![CDATA[$workflow]]></code>
169+
</MissingParamType>
158170
</file>
159171
<file src="src/Client/WorkflowOptions.php">
160172
<ImpureMethodCall>
@@ -384,6 +396,14 @@
384396
</MissingParamType>
385397
</file>
386398
<file src="src/Internal/Client/WorkflowStarter.php">
399+
<InvalidArgument>
400+
<code><![CDATA[0]]></code>
401+
<code><![CDATA[1]]></code>
402+
<code><![CDATA[1]]></code>
403+
</InvalidArgument>
404+
<MissingTemplateParam>
405+
<code><![CDATA[$fails]]></code>
406+
</MissingTemplateParam>
387407
<PossiblyNullArgument>
388408
<code><![CDATA[$options->retryOptions ? $options->retryOptions->toWorkflowRetryPolicy() : null]]></code>
389409
<code><![CDATA[$options->toMemo($this->converter)]]></code>
@@ -395,6 +415,9 @@
395415
<RedundantConditionGivenDocblockType>
396416
<code><![CDATA[$delay !== null]]></code>
397417
</RedundantConditionGivenDocblockType>
418+
<UndefinedInterfaceMethod>
419+
<code><![CDATA[toHeader]]></code>
420+
</UndefinedInterfaceMethod>
398421
</file>
399422
<file src="src/Internal/Client/WorkflowStub.php">
400423
<PossiblyInvalidArgument>
@@ -405,6 +428,7 @@
405428
<code><![CDATA[$attr->getFailure()]]></code>
406429
<code><![CDATA[$attr->getResult()]]></code>
407430
<code><![CDATA[$input->workflowType]]></code>
431+
<code><![CDATA[$input->workflowType]]></code>
408432
<code><![CDATA[$result->getQueryResult()]]></code>
409433
<code><![CDATA[$this->execution]]></code>
410434
<code><![CDATA[$this->execution]]></code>

src/Internal/Client/WorkflowStarter.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ public function start(
8282
}
8383

8484
/**
85+
* @param non-empty-string $workflowType
86+
* @param non-empty-string $signal
87+
*
8588
* @throws ServiceClientException
8689
* @throws WorkflowExecutionAlreadyStartedException
8790
*/

tests/Acceptance/App/Runtime/RRStarter.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace Temporal\Tests\Acceptance\App\Runtime;
66

77
use Temporal\Testing\Environment;
8+
use Temporal\Testing\SystemInfo;
89

910
final class RRStarter
1011
{
@@ -24,9 +25,11 @@ public function start(): void
2425
return;
2526
}
2627

28+
$sysInfo = SystemInfo::detect();
2729
$run = $this->runtime->command;
30+
2831
$rrCommand = [
29-
$this->runtime->workDir . DIRECTORY_SEPARATOR . 'rr',
32+
$this->runtime->workDir . DIRECTORY_SEPARATOR . $sysInfo->rrExecutable,
3033
'serve',
3134
'-w',
3235
$this->runtime->rrConfigDir,

0 commit comments

Comments
 (0)