Fix WorkflowInit detection (#611)

* Fix WorkflowInit detection

* Add tests

Author: roxblnfk

src/Internal/Declaration/Reader/WorkflowReader.php

@@ -128,8 +128,12 @@ private function withMethods(ClassNode $graph, WorkflowPrototype $prototype): Wo
 
             // Check WorkflowInit method
             if ($method->isConstructor()) {
-                $this->getAttributedMethod($graph, $method, WorkflowInit::class);
-                $prototype->setHasInitializer(true);
+                $attr = $this->getAttributedMethod($graph, $method, WorkflowInit::class);
+
+                if ($attr !== null) {
+                    $prototype->setHasInitializer(true);
+                }
+
                 continue;
             }
 

tests/Unit/Declaration/Fixture/WorkflowWithConstructor.php

@@ -0,0 +1,28 @@
+<?php
+
+/**
+ * This file is part of Temporal package.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Temporal\Tests\Unit\Declaration\Fixture;
+
+use Temporal\Workflow\WorkflowInterface;
+use Temporal\Workflow\WorkflowMethod;
+
+/** @WorkflowInterface */
+#[WorkflowInterface]
+class WorkflowWithConstructor
+{
+    public function __construct() {}
+
+    /**
+     * @WorkflowMethod
+     */
+    #[WorkflowMethod]
+    public function handler(): void {}
+}

tests/Unit/Declaration/Fixture/WorkflowWithWorkflowInit.php

@@ -0,0 +1,33 @@
+<?php
+
+/**
+ * This file is part of Temporal package.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Temporal\Tests\Unit\Declaration\Fixture;
+
+use Temporal\Workflow\WorkflowInit;
+use Temporal\Workflow\WorkflowInterface;
+use Temporal\Workflow\WorkflowMethod;
+
+/** @WorkflowInterface */
+#[WorkflowInterface]
+class WorkflowWithWorkflowInit
+{
+    /**
+     * @WorkflowInit
+     */
+    #[WorkflowInit]
+    public function __construct() {}
+
+    /**
+     * @WorkflowMethod
+     */
+    #[WorkflowMethod]
+    public function handler(): void {}
+}

tests/Unit/Declaration/WorkflowDeclarationTestCase.php

@@ -21,13 +21,15 @@
 use Temporal\Internal\Declaration\Reader\WorkflowReader;
 use Temporal\Tests\Unit\Declaration\Fixture\Inheritance\ExtendingWorkflow;
 use Temporal\Tests\Unit\Declaration\Fixture\SimpleWorkflow;
+use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithConstructor;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithCron;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithCronAndRetry;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithCustomName;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithoutHandler;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithQueries;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithRetry;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithSignals;
+use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithWorkflowInit;
 use Temporal\Tests\Workflow\AggregatedWorkflowImpl;
 
 /**
@@ -203,6 +205,18 @@ public function testWorkflowHandlerWithName(WorkflowReader $reader): void
         $this->assertSame('ExampleWorkflowName', $prototype->getID());
     }
 
+    /**
+     * @param WorkflowReader $reader
+     * @throws \ReflectionException
+     */
+    #[TestDox("Reading workflow with WorkflowInit attribute")]
+    #[DataProvider('workflowReaderDataProvider')]
+    public function testWorkflowWithInitConstructor(WorkflowReader $reader): void
+    {
+        $this->assertTrue($reader->fromClass(WorkflowWithWorkflowInit::class)->hasInitializer());
+        $this->assertFalse($reader->fromClass(WorkflowWithConstructor::class)->hasInitializer());
+    }
+
     public function testHierarchicalWorkflow(): void
     {
         $instantiator = new WorkflowInstantiator(new \Temporal\Interceptor\SimplePipelineProvider());