Adjust default values (#60)

Adjust default workflow/activity options.

Author: wolfy-j

src/Client/WorkflowOptions.php

@@ -82,7 +82,7 @@ final class WorkflowOptions extends Options
      * The timeout for processing workflow task from the time the worker pulled
      * this task. If a workflow task is lost, it is retried after this timeout.
      *
-     * Optional: defaulted to 10 secs.
+     * Optional: defaulted to no limit
      */
     #[Marshal(name: 'WorkflowTaskTimeout', type: DateIntervalType::class)]
     public \DateInterval $workflowTaskTimeout;
@@ -135,9 +135,9 @@ final class WorkflowOptions extends Options
     public function __construct()
     {
         $this->workflowId = Uuid::v4();
-        $this->workflowExecutionTimeout = CarbonInterval::years(10);
-        $this->workflowRunTimeout = CarbonInterval::years(10);
-        $this->workflowTaskTimeout = CarbonInterval::seconds(10);
+        $this->workflowExecutionTimeout = CarbonInterval::seconds(0);
+        $this->workflowRunTimeout = CarbonInterval::seconds(0);
+        $this->workflowTaskTimeout = CarbonInterval::seconds(0);
         $this->retryOptions = new RetryOptions();
 
         parent::__construct();

src/Workflow/ChildWorkflowOptions.php

@@ -72,7 +72,7 @@ final class ChildWorkflowOptions extends Options
      * The end to end timeout for the child workflow execution including
      * retries and continue as new.
      *
-     * Optional: defaults to 10 years
+     * Optional: defaults is no limit
      */
     #[Marshal(name: 'WorkflowExecutionTimeout', type: DateIntervalType::class)]
     public \DateInterval $workflowExecutionTimeout;
@@ -91,7 +91,7 @@ final class ChildWorkflowOptions extends Options
     /**
      * The workflow task timeout for the child workflow.
      *
-     * Optional: default is 10s if this is not provided (or if 0 is provided).
+     * Optional: default is no limit
      */
     #[Marshal(name: 'WorkflowTaskTimeout', type: DateIntervalType::class)]
     public \DateInterval $workflowTaskTimeout;
@@ -164,9 +164,9 @@ final class ChildWorkflowOptions extends Options
      */
     public function __construct()
     {
-        $this->workflowExecutionTimeout = CarbonInterval::years(10);
-        $this->workflowRunTimeout = CarbonInterval::years(10);
-        $this->workflowTaskTimeout = CarbonInterval::seconds(10);
+        $this->workflowExecutionTimeout = CarbonInterval::seconds(0);
+        $this->workflowRunTimeout = CarbonInterval::seconds(0);
+        $this->workflowTaskTimeout = CarbonInterval::seconds(0);
         $this->retryOptions = new RetryOptions();
 
         parent::__construct();

src/Workflow/ContinueAsNewOptions.php

@@ -48,7 +48,7 @@ final class ContinueAsNewOptions
     /**
      * The workflow task timeout for the child workflow.
      *
-     * Optional: default is 10s if this is not provided (or if 0 is provided).
+     * Optional: default is no limit
      */
     #[Marshal(name: 'WorkflowTaskTimeout', type: DateIntervalType::class)]
     public \DateInterval $workflowTaskTimeout;
@@ -58,8 +58,8 @@ final class ContinueAsNewOptions
      */
     public function __construct()
     {
-        $this->workflowRunTimeout = CarbonInterval::years(10);
-        $this->workflowTaskTimeout = CarbonInterval::seconds(10);
+        $this->workflowRunTimeout = CarbonInterval::seconds(0);
+        $this->workflowTaskTimeout = CarbonInterval::seconds(0);
     }
 
     /**

tests/Fixtures/data/Test_ActivityStubWorkflow.log

@@ -1,4 +1,4 @@
-2021/01/12 15:25:13	DEBUG	[{"id":1,"command":"StartWorkflow","options":{"info":{"WorkflowExecution":{"ID":"abd6d54b-e24e-4790-a7f9-37056176783e","RunID":"3088cdc7-bcae-4f49-940c-8bf30f7f4e18"},"WorkflowType":{"Name":"ActivityStubWorkflow"},"TaskQueueName":"default","WorkflowExecutionTimeout":315360000000000000,"WorkflowRunTimeout":315360000000000000,"WorkflowTaskTimeout":10000000000,"Namespace":"default","Attempt":1,"CronSchedule":"","ContinuedExecutionRunID":"","ParentWorkflowNamespace":"","ParentWorkflowExecution":null,"Memo":null,"SearchAttributes":null,"BinaryChecksum":"8646d54f9f6b22f407d6d22254eea9f5"}},"payloads":"CicKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SDSJoZWxsbyB3b3JsZCI="}] {"taskQueue":"default","tickTime":"2021-01-12T15:25:13.3983204Z"}
+2021/01/12 15:25:13	DEBUG	[{"id":1,"command":"StartWorkflow","options":{"info":{"WorkflowExecution":{"ID":"abd6d54b-e24e-4790-a7f9-37056176783e","RunID":"3088cdc7-bcae-4f49-940c-8bf30f7f4e18"},"WorkflowType":{"Name":"ActivityStubWorkflow"},"TaskQueueName":"default","WorkflowExecutionTimeout":315360000000000000,"WorkflowRunTimeout":315360000000000000,"WorkflowTaskTimeout":0,"Namespace":"default","Attempt":1,"CronSchedule":"","ContinuedExecutionRunID":"","ParentWorkflowNamespace":"","ParentWorkflowExecution":null,"Memo":null,"SearchAttributes":null,"BinaryChecksum":"8646d54f9f6b22f407d6d22254eea9f5"}},"payloads":"CicKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SDSJoZWxsbyB3b3JsZCI="}] {"taskQueue":"default","tickTime":"2021-01-12T15:25:13.3983204Z"}
 2021/01/12 15:25:13	DEBUG	[{"id":9001,"command":"ExecuteActivity","options":{"name":"SimpleActivity.echo","options":{"TaskQueueName":"default","ScheduleToCloseTimeout":0,"ScheduleToStartTimeout":0,"StartToCloseTimeout":5000000000,"HeartbeatTimeout":0,"WaitForCancellation":false,"ActivityID":"","RetryPolicy":{"initial_interval":null,"backoff_coefficient":2,"maximum_interval":null,"maximum_attempts":1,"non_retryable_error_types":[]}}},"payloads":"CicKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SDSJoZWxsbyB3b3JsZCI="},{"id":1,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"}]	{"receive": true}
 2021/01/12 15:25:13	DEBUG	[{"id":9001,"payloads":"CicKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SDSJIRUxMTyBXT1JMRCI="}] {"taskQueue":"default","tickTime":"2021-01-12T15:25:13.4849445Z"}
 2021/01/12 15:25:13	DEBUG	[{"id":9002,"command":"ExecuteActivity","options":{"name":"SimpleActivity.echo","options":{"TaskQueueName":"default","ScheduleToCloseTimeout":0,"ScheduleToStartTimeout":0,"StartToCloseTimeout":1000000000,"HeartbeatTimeout":0,"WaitForCancellation":false,"ActivityID":"","RetryPolicy":{"initial_interval":null,"backoff_coefficient":2,"maximum_interval":null,"maximum_attempts":1,"non_retryable_error_types":[]}}},"payloads":"CiMKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SCSJ1bnR5cGVkIg=="}]	{"receive": true}

tests/Fixtures/data/Test_BatchedSignal.log

@@ -1,4 +1,4 @@
-2021/01/27 06:51:20	DEBUG	[{"id":7,"command":"StartWorkflow","options":{"info":{"WorkflowExecution":{"ID":"b4881b9a-e0a8-4433-b330-27457af9d2c0","RunID":"d453e8be-c071-40fa-b342-9bf1197b6b2a"},"WorkflowType":{"Name":"Signal.greet"},"TaskQueueName":"default","WorkflowExecutionTimeout":60000000000,"WorkflowRunTimeout":60000000000,"WorkflowTaskTimeout":10000000000,"Namespace":"default","Attempt":1,"CronSchedule":"","ContinuedExecutionRunID":"","ParentWorkflowNamespace":"","ParentWorkflowExecution":null,"Memo":null,"SearchAttributes":null,"BinaryChecksum":"9f3a48a8f2d7bb5fae539d23df402a74"}}}] {"taskQueue":"default","tickTime":"2021-01-27T06:51:20Z"}
+2021/01/27 06:51:20	DEBUG	[{"id":7,"command":"StartWorkflow","options":{"info":{"WorkflowExecution":{"ID":"b4881b9a-e0a8-4433-b330-27457af9d2c0","RunID":"d453e8be-c071-40fa-b342-9bf1197b6b2a"},"WorkflowType":{"Name":"Signal.greet"},"TaskQueueName":"default","WorkflowExecutionTimeout":60000000000,"WorkflowRunTimeout":60000000000,"WorkflowTaskTimeout":0,"Namespace":"default","Attempt":1,"CronSchedule":"","ContinuedExecutionRunID":"","ParentWorkflowNamespace":"","ParentWorkflowExecution":null,"Memo":null,"SearchAttributes":null,"BinaryChecksum":"9f3a48a8f2d7bb5fae539d23df402a74"}}}] {"taskQueue":"default","tickTime":"2021-01-27T06:51:20Z"}
 2021/01/27 06:51:20	DEBUG	[{"id":7,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"}]	{"receive": true}
 2021/01/27 06:51:20	DEBUG	[{"id":8,"command":"InvokeSignal","options":{"runId":"d453e8be-c071-40fa-b342-9bf1197b6b2a","name":"addName"},"payloads":"CiIKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SCCJBbnRvbnki"}] {"taskQueue":"default","tickTime":"2021-01-27T06:51:20Z"}
 2021/01/27 06:51:20	DEBUG	[{"id":8,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"}]	{"receive": true}

tests/Fixtures/data/Test_BatchedSignal_01.log

@@ -1,4 +1,4 @@
-2021/01/27 06:53:20	DEBUG	[{"id":1,"command":"StartWorkflow","options":{"info":{"WorkflowExecution":{"ID":"388c01c0-9e5d-4634-9444-2fc13e4b68e5","RunID":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966"},"WorkflowType":{"Name":"Signal.greet"},"TaskQueueName":"default","WorkflowExecutionTimeout":60000000000,"WorkflowRunTimeout":60000000000,"WorkflowTaskTimeout":10000000000,"Namespace":"default","Attempt":1,"CronSchedule":"","ContinuedExecutionRunID":"","ParentWorkflowNamespace":"","ParentWorkflowExecution":null,"Memo":null,"SearchAttributes":null,"BinaryChecksum":"9f3a48a8f2d7bb5fae539d23df402a74"}}},{"id":2,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"addName"},"payloads":"CiIKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SCCJBbnRvbnki"},{"id":3,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"addName"},"payloads":"CiAKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SBiJKb2huIg=="},{"id":4,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"addName"},"payloads":"Ch8KFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SBSJCb2Ii"},{"id":5,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"exit"}}] {"taskQueue":"default","tickTime":"2021-01-27T06:53:20Z"}
+2021/01/27 06:53:20	DEBUG	[{"id":1,"command":"StartWorkflow","options":{"info":{"WorkflowExecution":{"ID":"388c01c0-9e5d-4634-9444-2fc13e4b68e5","RunID":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966"},"WorkflowType":{"Name":"Signal.greet"},"TaskQueueName":"default","WorkflowExecutionTimeout":60000000000,"WorkflowRunTimeout":60000000000,"WorkflowTaskTimeout":0,"Namespace":"default","Attempt":1,"CronSchedule":"","ContinuedExecutionRunID":"","ParentWorkflowNamespace":"","ParentWorkflowExecution":null,"Memo":null,"SearchAttributes":null,"BinaryChecksum":"9f3a48a8f2d7bb5fae539d23df402a74"}}},{"id":2,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"addName"},"payloads":"CiIKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SCCJBbnRvbnki"},{"id":3,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"addName"},"payloads":"CiAKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SBiJKb2huIg=="},{"id":4,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"addName"},"payloads":"Ch8KFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SBSJCb2Ii"},{"id":5,"command":"InvokeSignal","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966","name":"exit"}}] {"taskQueue":"default","tickTime":"2021-01-27T06:53:20Z"}
 2021/01/27 06:53:20	DEBUG	[{"id":1,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"},{"id":2,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"},{"id":3,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"},{"id":4,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"},{"id":5,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"},{"id":9001,"command":"CompleteWorkflow","options":{},"payloads":"CkkKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SL1siSGVsbG8sIEFudG9ueSEiLCJIZWxsbywgSm9obiEiLCJIZWxsbywgQm9iISJd"}]	{"receive": true}
 2021/01/27 06:53:20	DEBUG	[{"id":9001,"payloads":"CiUKFgoIZW5jb2RpbmcSCmpzb24vcGxhaW4SCyJjb21wbGV0ZWQi"},{"id":6,"command":"DestroyWorkflow","options":{"runId":"98b6d77e-fa56-4c8a-a341-a8c7e53f6966"}}] {"taskQueue":"default","tickTime":"2021-01-27T06:53:20Z","replay":true}
 2021/01/27 06:53:20	DEBUG	[{"id":6,"payloads":"ChkKFwoIZW5jb2RpbmcSC2JpbmFyeS9udWxs"}]	{"receive": true}