Make Workflow Context readonly during init

Author: roxblnfk

src/Internal/Workflow/Process/Process.php

@@ -208,6 +208,8 @@ public function initAndStart(
                 $instance->init();
             }
 
+            $context->setReadonly(false);
+
             // Execute
             //
             // Run workflow handler in an interceptor pipeline
@@ -234,7 +236,7 @@ function (WorkflowInput $input) use ($context, $arguments, $handler, $deferred):
                 ));
         } catch (\Throwable $e) {
             /** @psalm-suppress RedundantPropertyInitializationCheck */
-            isset($this->context) or $this->setContext($context);
+            isset($this->context) or $this->setContext($context->setReadonly(false));
             $this->complete($e);
         } finally {
             Workflow::setCurrentContext(null);

src/Internal/Workflow/WorkflowContext.php

@@ -89,6 +89,7 @@ class WorkflowContext implements WorkflowContextInterface, HeaderCarrier, Destro
 
     private array $trace = [];
     private bool $continueAsNew = false;
+    private bool $readonly = true;
 
     /** @var Pipeline<WorkflowOutboundRequestInterceptor, PromiseInterface> */
     private Pipeline $requestInterceptor;
@@ -148,9 +149,10 @@ public function getInput(): ValuesInterface
         return $this->input->input;
     }
 
-    public function setInput(Input $input): void
+    public function setReadonly(bool $value = true): static
     {
-        $this->input = $input;
+        $this->readonly = $value;
+        return $this;
     }
 
     public function withInput(Input $input): static
@@ -460,6 +462,7 @@ public function request(
         bool $cancellable = true,
         bool $waitResponse = true,
     ): PromiseInterface {
+        $this->readonly and throw new \RuntimeException('Workflow is not initialized.');
         $this->recordTrace();
 
         // Intercept workflow outbound calls

tests/Acceptance/Extra/Interceptors/ContextTest.php

@@ -5,9 +5,11 @@
 namespace Temporal\Tests\Acceptance\Extra\Interceptors\Context;
 
 use PHPUnit\Framework\Attributes\Test;
+use React\Promise\PromiseInterface;
 use Temporal\Activity;
 use Temporal\Client\WorkflowStubInterface;
 use Temporal\DataConverter\EncodedValues;
+use Temporal\DataConverter\Type;
 use Temporal\Exception\Client\WorkflowFailedException;
 use Temporal\Exception\Failure\ApplicationFailure;
 use Temporal\Interceptor\ActivityInbound\ActivityInput;
@@ -65,6 +67,13 @@ public function failInInterceptorExecute(
             self::assertStringContainsString('exception-in-execute', $prev->getOriginalMessage());
         }
     }
+
+    #[Test]
+    public function readonlyContextInConstructor(
+        #[Stub('Extra_Interceptors_Context_Readonly')] WorkflowStubInterface $stub,
+    ): void {
+        self::assertTrue($stub->getResult(Type::TYPE_BOOL), 'Workflow instance in context is not readonly');
+    }
 }
 
 class WorkerServices
@@ -131,6 +140,28 @@ public function handle(mixed ...$input)
     }
 }
 
+#[WorkflowInterface]
+class TestReadonlyConstructorWorkflow
+{
+    private ?PromiseInterface $uuid = null;
+
+    #[Workflow\WorkflowInit]
+    public function __construct(mixed ...$input)
+    {
+        try {
+            $this->uuid = Workflow::uuid7();
+        } catch (\Throwable $e) {
+            $e->getMessage() === 'Workflow is not initialized.' or throw $e;
+        }
+    }
+
+    #[WorkflowMethod(name: "Extra_Interceptors_Context_Readonly")]
+    public function handle()
+    {
+        return $this->uuid === null;
+    }
+}
+
 #[Activity\ActivityInterface(prefix: 'Extra_Interceptors_Context.')]
 class TestActivity
 {